Ticket #1556 (closed enhancement: fixed)

Opened 10 years ago

Last modified 10 years ago

editor search: button [ Find all ]

Reported by: dborca Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre3
Component: mcedit Version: master
Keywords: Cc: dborca
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

A nice addition would be "set bookmarks" option in Editor Search. Especially with colored bookmarks (Ticket #1484)

Attachments

search_title_2.diff (3.7 KB) - added by dmartina 10 years ago.
Fix buttons position

Change History

comment:1 Changed 10 years ago by angel_il

  • Reporter changed from angel_il to dborca

comment:2 Changed 10 years ago by angel_il

  • Summary changed from editor: search all to editor search: button [ Find all ]

comment:3 Changed 10 years ago by angel_il

  • severity changed from no branch to on review

branch: 1556_find_all (parent: 1487_whole_words)
changeset: f102314673d559c13c8b779154ab1eb586e6f88d

comment:4 Changed 10 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il

comment:5 Changed 10 years ago by andrew_b

  • Blocking 1560 added

comment:6 Changed 10 years ago by slavazanko

  • Blocked By 1562 added

comment:7 Changed 10 years ago by andrew_b

  • Blocked By 1562 removed

(In #1562) Merged to master.
Initial changeset:f9d6bb075c9cbed89aba9f6e3a201b32e0786399
Final changeset:c057b0a02a69c69ad528ab267bd140d4bef3f358

git log --pretty=oneline 44a094c..bf7b330

comment:8 Changed 10 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:9 Changed 10 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • severity changed from on review to approved

comment:10 Changed 10 years ago by angel_il

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:11 Changed 10 years ago by angel_il

  • Status changed from testing to closed
  • Cc dborca added

comment:12 Changed 10 years ago by dmartina

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Blocking 1370 added

I18N: I suppose this belongs here... After updating to git with this improvements in search dialog, the "Enter search string:" label is not translated. The string is in my es.po and it's the same for F7/search and F4/replace. I also notice something weird about horizontal placement. I have uploaded my latest es.po with the "Find All" label in #1370.

comment:13 Changed 10 years ago by slavazanko

  • Votes for changeset commited-master deleted
  • severity changed from merged to no branch

comment:14 Changed 10 years ago by dmartina

Label is translated, dialog title "Search" is not. Horizontal position of widgets are one to the left.

comment:15 Changed 10 years ago by andrew_b

  • Status changed from reopened to accepted
  • Owner changed from angel_il to andrew_b

Created 1556_find_all_i18n branch. Parent branch: master.
changeset:edb5d0f62ee3d68f6662c4a27bb7fbecb9e5dbc9

comment:16 Changed 10 years ago by andrew_b

Sorry, there are some problems with connections to m-c.o/git. I'll publish the branch ASAP.

comment:17 follow-up: ↓ 18 Changed 10 years ago by andrew_b

  • severity changed from no branch to on review

Now everything is OK.
Review please.

comment:18 in reply to: ↑ 17 Changed 10 years ago by dmartina

Replying to andrew_b:

Now everything is OK.
Review please.

Fine now. The patch seems to do the job.

comment:19 follow-up: ↓ 20 Changed 10 years ago by dmartina

Hmm... Doesn't resize on large buttons. Try a "loooooooooooooooong Find All".

Changed 10 years ago by dmartina

Fix buttons position

comment:20 in reply to: ↑ 19 Changed 10 years ago by andrew_b

Replying to dmartina:

Hmm... Doesn't resize on large buttons. Try a "loooooooooooooooong Find All".

You're right. Thanks a lot for your help.
changeset:6767836b1ab570dd30264e00a70a76e84b7fee53 (forced update)

comment:21 Changed 10 years ago by andrew_b

  • Blocking 64 added

comment:22 Changed 10 years ago by andrew_b

  • Blocking 1621 added

(In #1621) The one piece of code is modified in several tickets. Thus set blockedby 1556.

comment:23 Changed 10 years ago by andrew_b

  • Blocking 1623 added

(In #1623) The one piece of code is modified in several tickets. Thus set blockedby #1556.

comment:24 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

comment:25 Changed 10 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:26 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset angel_il slavazanko deleted
  • Resolution set to fixed
  • Blocking 64, 1370, 1560, 1621, 1623 removed
  • severity changed from approved to merged

Merged to master.
changeset:434ebd3780d400cffa274b96ea29614e668f58fc

All other dialogs will be fixed in #64.

comment:27 Changed 10 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.