Ticket #1562 (closed task: fixed)

Opened 9 years ago

Last modified 9 years ago

Simplification of QuickDialog API

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre3
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

Currently, all QuickWidget? fields must be defined for every quick widget put to quick dialog. The some simplification is proposed. Compare the old code:

{quick_checkbox, 33, REPLACE_DLG_WIDTH, 10, REPLACE_DLG_HEIGHT, N_("Whole &words"), 0, 0,
&twhole_words, 0, NULL, NULL, NULL},

with the new one:

QUICK_CHECK (33, REPLACE_DLG_WIDTH, 10, REPLACE_DLG_HEIGHT, N_("&Whole words"), &edit->whole_words),

Branch: DEV_quick_widget.
changeset:ecc806264c805beb7957499e168ae9d38f24392c
Also quick dialogs with non-standard button location was reimplemented: 'Confirmation', 'Display bits'.

Change History

comment:1 Changed 9 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted

comment:2 Changed 9 years ago by slavazanko

  • Blocking 1400 added

comment:3 Changed 9 years ago by iNode

  • Description modified (diff)
  • Summary changed from Simplification of QuicjDialog API to Simplification of QuickDialog API

comment:4 Changed 9 years ago by andrew_b

  • severity changed from on review to no branch

comment:5 Changed 9 years ago by andrew_b

  • Blocking 1575 added

comment:6 Changed 9 years ago by andrew_b

  • Description modified (diff)
  • severity changed from no branch to on review

comment:7 Changed 9 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:8 follow-up: ↓ 9 Changed 9 years ago by dmartina

Segmentation fault: Editor/options/general

Both with "mc" (Spanish system locale) and "LANG= mc"

comment:9 in reply to: ↑ 8 Changed 9 years ago by andrew_b

Replying to dmartina:

Segmentation fault: Editor/options/general

Thanks! Fixed in changeset:ded24579da4d9f27d958a51cde278b7dd4c23f41

comment:10 Changed 9 years ago by slavazanko

  • Blocking 1556, 1560 added

comment:11 Changed 9 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:12 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to commited-master
  • Resolution set to fixed
  • Blocking 1400, 1556, 1560, 1575 removed
  • severity changed from approved to merged

Merged to master.
Initial changeset:f9d6bb075c9cbed89aba9f6e3a201b32e0786399
Final changeset:c057b0a02a69c69ad528ab267bd140d4bef3f358

git log --pretty=oneline 44a094c..bf7b330

comment:13 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.