Ticket #1557 (closed defect: fixed)
mcview must be faster
Reported by: | angel_il | Owned by: | slavazanko |
---|---|---|---|
Priority: | blocker | Milestone: | 4.7.0-pre2 |
Component: | mc-core | Version: | 4.7.0-pre1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | Votes for changeset: | committed-master |
Description
mcview must be faster and code must be refactored.
need drop code after 4.6.2 and replace to new fastest UTF-8...
Change History
comment:2 Changed 15 years ago by angel_il
- severity changed from no branch to on review
branch: DEV_mcview2 (parent: master)
changeset: c5cef456ba3726b916066aba78cd8eafb9a59403
comment:3 Changed 15 years ago by angel_il
start commit: 1fac156088386025afc127b5d00ee2e19449bf38
comment:4 Changed 15 years ago by slavazanko
- Status changed from new to accepted
- Owner set to slavazanko
- Votes for changeset set to slavazanko
comment:5 Changed 15 years ago by angel_il
changeset: ffac3ab7a93b5bab404edad41e3e8b6b47b7c205 (rebased)
comment:6 Changed 15 years ago by angel_il
- Votes for changeset slavazanko deleted
need fix this
In file included from actions_cmd.c:63: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift actions_cmd.c: In function 'mcview_check_left_right_keys': actions_cmd.c:175: warning: comparison is always true due to limited range of data type actions_cmd.c:178: warning: large integer implicitly truncated to unsigned type In file included from coord_cache.c:55: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift In file included from datasource.c:61: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift In file included from dialogs.c:42: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift In file included from display.c:45: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift In file included from growbuf.c:43: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift In file included from hex.c:49: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift In file included from lib.c:45: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift lib.c: In function 'mcview_toggle_wrap_mode': lib.c:91: warning: passing argument 3 of 'mcview_offset_to_coord' from incompatible pointer type lib.c:92: warning: passing argument 2 of 'mcview_coord_to_offset' from incompatible pointer type lib.c: In function 'mcview_select_encoding': lib.c:209: warning: implicit declaration of function 'get_codepage_id' lib.c:209: warning: assignment makes pointer from integer without a cast In file included from mcviewer.c:46: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift mcviewer.c: In function 'mcview_viewer': mcviewer.c:252: warning: implicit declaration of function 'mcview_load' mcviewer.c: In function 'mcview_load': mcviewer.c:284: warning: implicit declaration of function 'get_codepage_id' mcviewer.c:284: warning: assignment makes pointer from integer without a cast In file included from move.c:58: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift move.c: In function 'mcview_move_up': move.c:121: warning: passing argument 2 of 'mcview_coord_to_offset' from incompatible pointer type move.c:128: warning: passing argument 2 of 'mcview_coord_to_offset' from incompatible pointer type move.c: In function 'mcview_move_down': move.c:179: warning: passing argument 2 of 'mcview_coord_to_offset' from incompatible pointer type move.c: In function 'mcview_scroll_to_cursor': move.c:252: warning: passing argument 2 of 'mcview_coord_to_offset' from incompatible pointer type move.c: In function 'mcview_moveto_bol': move.c:309: warning: passing argument 2 of 'mcview_coord_to_offset' from incompatible pointer type move.c: In function 'mcview_moveto_eol': move.c:336: warning: passing argument 2 of 'mcview_coord_to_offset' from incompatible pointer type move.c: In function 'mcview_coord_to_offset': move.c:376: warning: implicit declaration of function 'mcview_ccache_lookup' In file included from nroff.c:45: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift nroff.c: In function 'mcview_display_nroff': nroff.c:104: warning: 'c_next' may be used uninitialized in this function nroff.c:103: warning: 'c_prev' may be used uninitialized in this function In file included from plain.c:45: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift In file included from search.c:44: ../../src/viewer/internal.h:35: warning: suggest parentheses around + or - inside shift
comment:9 Changed 15 years ago by slavazanko
- Votes for changeset changed from angel_il to angel_il slavazanko
- severity changed from on review to approved
comment:10 Changed 15 years ago by slavazanko
- Status changed from accepted to testing
- Votes for changeset changed from angel_il slavazanko to commited-master
- Resolution set to fixed
- Blocking 1504, 1530 removed
- severity changed from approved to merged
Note: See
TracTickets for help on using
tickets.