Ticket #1396 (closed enhancement: fixed)
need build option --with-search-engine for select regex engine
Reported by: | angel_il | Owned by: | slavazanko |
---|---|---|---|
Priority: | minor | Milestone: | 4.7.0 |
Component: | mc-core | Version: | master |
Keywords: | m4 autoconf | Cc: | zaytsev, |
Blocked By: | Blocking: | ||
Branch state: | Votes for changeset: | committed-master |
Description
need add build option --with-search-engine for select regex engine, pcre or glib
Change History
comment:1 Changed 15 years ago by angel_il
- Version changed from 4.6.2 to master
- Milestone changed from 4.7 to 4.7.0-pre1
comment:2 Changed 15 years ago by angel_il
- Priority changed from major to minor
- Type changed from defect to enhancement
- severity changed from no branch to on review
Branch: 1396_with_search_engine (parrent: master)
changeset: 30e2dd32cbb3b16d68b2e42337579efd90b8cea5
comment:3 Changed 15 years ago by angel_il
- Status changed from new to assigned
- Owner set to slavazanko
comment:4 Changed 15 years ago by slavazanko
- Status changed from assigned to accepted
branch rebased.
Initial changeset:1b03ffad49188350e8c513d0046c68b9a0109508
review, please.
comment:6 Changed 15 years ago by andrew_b
- Votes for changeset changed from angel_il to angel_il andrew_b
- severity changed from on review to approved
comment:7 Changed 15 years ago by slavazanko
- Status changed from accepted to testing
- Resolution set to fixed
- severity changed from approved to merged
Merged into master.
Merge changeset:6e9059e2f30a6c2ace30ed2fe3c597a1cfa60319
comment:9 Changed 15 years ago by angel_il
- Votes for changeset changed from angel_il andrew_b to commited-master
comment:10 Changed 15 years ago by zaytsev
- Status changed from closed to reopened
- Resolution fixed deleted
Check out build logs for EL5. Old GLIB, PCRE installed:
http://rpm.zaytsev.net/mc/epel-5-i386/build.log
Search type: glib-regexp
This shouldn't happen.
Last known good build from master: Tue, 7 Jul 2009 04:15:01 +0400 ...
comment:13 Changed 15 years ago by slavazanko
- Keywords m4 autoconf added
- Votes for changeset commited-master deleted
- severity changed from merged to on review
- Milestone changed from 4.7 to 4.7.0
Check out build logs for EL5. Old GLIB, PCRE installed:
http://rpm.zaytsev.net/mc/epel-5-i386/build.log
Hm... link to external dynamically-changed file is not good idea .
But I review '--with-search-engine' stuff and I found some bugs.
Created branch 1396_with_search_engine
Initial changeset:fe53f99d09cfb48f18b599eff48397f22b133e9b
Review, please.
comment:15 Changed 15 years ago by zaytsev
Hi Slava!
True, but does not matter, the bug is still here. You see what I mean?
Configuration: Source code location: . ... Search type: glib-regexp
And in fact, it builds against PCRE!
Z.
comment:16 Changed 15 years ago by slavazanko
- 8cf1684eeea6f26ae965b9ae505ad7ef51611a0b: Fixed incorrect showing name of search library in summary screen
Review, please.
comment:17 Changed 15 years ago by andrew_b
My vote is still live. :)
comment:19 Changed 15 years ago by zaytsev
- Votes for changeset changed from andrew_b to andrew_b zaytsev
comment:20 Changed 15 years ago by slavazanko
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b zaytsev to commited-master
- Resolution set to fixed
- severity changed from on review to merged