Ticket #1397 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

maillist: Today's git seems to be broken

Reported by: slavazanko Owned by: slavazanko
Priority: blocker Milestone: 4.7.0-pre1
Component: mcview Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

From: Denys Vlasenko.


I simply run:

./autogen.sh
./configure
make

and it ends with

gcc -std=gnu99 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-I.. -g -O2 -Wall -o mc achown.o background.o boxes.o chmod.o chown.o
cmd.o color.o command.o complete.o cons.handler.o dialog.o dir.o
execute.o ext.o file.o filegui.o filenot.o fileopctx.o find.o findme.o
glibcompat.o help.o hotlist.o info.o key.o keyxdef.o layout.o learn.o
listmode.o logging.o main.o menu.o mountlist.o mouse.o option.o
panelize.o popt.o poptconfig.o popthelp.o poptparse.o rxvt.o screen.o
setup.o slint.o subshell.o textconf.o tree.o treestore.o tty.o user.o
util.o utilunix.o view.o widget.o win.o wtools.o x11conn.o ecs.o
strutil.o strutilascii.o strutil8bit.o strutilutf8.o strescape.o
-Wl,--export-dynamic  ../edit/libedit.a ../vfs/libvfs-mc.a
-lgmodule-2.0 -ldl -lglib-2.0 -lslang search/.libs/libsearch.a
mcconfig/.libs/libmcconfig.a
view.o: In function `view_search_cmd':
/root/srcdevel/mc/fix/mc.t9/src/view.c:3328: undefined reference to
`str_convert_to_input'
collect2: ld returned 1 exit status
make[3]: *** [mc] Error 1
make[3]: Leaving directory `/root/srcdevel/mc/fix/mc.t9/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/root/srcdevel/mc/fix/mc.t9/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/root/srcdevel/mc/fix/mc.t9'
make: *** [all] Error 2

I'd hazard to guess src/charsets.c is not wired up into Makefile machinery...

Change History

comment:1 follow-up: ↓ 2 Changed 10 years ago by zaytsev

Maybe while fixing this bug you can also skim through the build options in

/contrib/dist/redhat/mc.spec.in

and remove all of the options that are on by default (slang) and maybe look through what's different between the options that EL/FC have and yours.

comment:2 in reply to: ↑ 1 Changed 10 years ago by andrew_b

This bug is occured if mc is built without --enable-charset option.

comment:3 Changed 10 years ago by slavazanko

  • Status changed from new to accepted

comment:4 Changed 10 years ago by slavazanko

  • severity changed from no branch to on review

Branch 1397_master_broken created (parent: master)

Initial changeset:a41156c007196d8b526707defd06684be9a6d363

review, please

comment:5 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

comment:6 Changed 10 years ago by slavazanko

  • Priority changed from major to blocker

comment:7 Changed 10 years ago by iNode

  • Votes for changeset changed from angel_il to angel_il iNode
  • severity changed from on review to approved

comment:8 Changed 10 years ago by slavazanko

  • Votes for changeset changed from angel_il iNode to merged-master
  • severity changed from approved to merged

comment:9 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:10 Changed 10 years ago by slavazanko

  • Status changed from testing to closed

comment:11 Changed 10 years ago by angel_il

  • Votes for changeset changed from merged-master to commited-master
Note: See TracTickets for help on using tickets.