Fish broken in recent versions

[Hubbitus]

Just on copy file over fish to remote server nothing happened.

Absolutely nothing - nor error, nor copy, nor any message. All seemed as copy done, but file absent on remote side.

mc-4.6.99.3-9-g1448fb9

[slavazanko]

Yes, error raised when I'm try to copy on fish (not from fish).

Bug need to close before 4.7.0-pre1

[slavazanko]

Created branch 1395_copy_to_fish_broken (parent: master)

Initial changeset:5c2ef00cf68a85ef2e58b61067c328a6cdcdb74a

Review, please

[iNode]

situation with

errno == EEXIST

can be more than in one case (just fish), but also on local FS in case of condition race
(file created after your check for existance).

I think you should also handle properly that case.

Also

open_flags &= ~O_EXCL;

can be replaced by more trivial

open_flags ^= O_EXCL;

[iNode]

It seems to be fish stat problem, because another remote fs like sshfs/nfs works correctly, i.e:

dd if=~/.profile of=./sshfs/.profile conv=excl

[slavazanko]

Branch rebased.

initial changeset:fc89bf6b73638771543f8e3c4eff34cf7f282814

[slavazanko]

branch rebased

changeset:f7c53720bc01e0bde0d20c366328c3a6cc7feaca

[iNode]

Can you place here TODO or FIXME keywords or open ticket to refactoring in VFS Standardisation milestone?

[slavazanko]

I think, after fixing this bug (as hack) to this ticket will added one of 'FIXME' or 'TODO' keywords and this ticket (in 'open' or 'reopen' state) will be moved into 'VFS Standartization' milestone.

Is this good way?

[iNode]

Yes. But I'm check that branch with as much ssh servers as possible and it broken.

It still don't copy file and segfault on copy directory with (empty) file in it.
I can reproduce it on different hosts with opennssh-server 5.1p1-5 (Debian 5) in my
network, but can't reproduced with 5.1p1-5 on m-c.o host (I think host RTT does matter here).

Just for check of mc version correctness:

$ git branch | grep '*'
* 1395_copy_to_fish_broken
$ git describe
4.6.99.3-21-gf7c5372
$ mc -V
GNU Midnight Commander 4.6.99.3-21-gf7c5372

[slavazanko]

review changeset:2de4bff68891d275c6c25d58c551e84c7ac56ab7

[slavazanko]

last commit rebased: changeset:8c7f848a785f9010e4cb0b42b5013e1ea90bf264

[iNode]

Good work. Thanks!

[slavazanko]

merge changeset:ddad204341808051adc19b3ed413a9b85213a103