Ticket #3652 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Glib-critical asserts in the GUI when doing mouse events in empty find list

Reported by: wwp Owned by:
Priority: minor Milestone: 4.8.18
Component: mc-core Version: master
Keywords: find glib critical assertion mouse Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

I get Glib-critical right in the middle of the user interface when I do some mouse actions over an empty find results list.

Clicking raises one (GLib-CRITICAL: g_queue_is_empty: assertion queue != NULL failed), double-clicking closes the find dialog (and aborts the running find) and it's unexpected, mouse scrolldown raises a glib-critical one about get_length() too.

The attached patch solves both of them, by NOT displaying a Glib-critical and NOT closing the running find (double-click).

Attachments

listbox-fix-assertion-emptylist-asserts-rev0.diff​ (1.2 KB) - added by wwp 8 years ago.
diff file against mc 4.8.17 sources

Change History

Changed 8 years ago by wwp

diff file against mc 4.8.17 sources

comment:1 Changed 8 years ago by andrew_b

  • Blocked By 3641 added

Applied with some modifications in 3641_cleanup branch.

comment:2 Changed 8 years ago by andrew_b

  • Blocked By 3641 removed

comment:3 Changed 8 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed

Applied as [e6297121977cf9aac79b4210f6cae93bd50d58fc].

Note: See TracTickets for help on using tickets.