Ticket #3539 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Warnings when building with -Wshadow, gcc 4.6.3

Reported by: zaytsev Owned by:
Priority: minor Milestone: 4.8.15
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description 

../../../src/viewer/datasource.c: In function ‘mcview_load_command_output’:
../../../src/viewer/datasource.c:398:16: warning: declaration of ‘pipe’ shadows a global declaration [-Wshadow]

../../../src/filemanager/dir.c: In function ‘dir_list_grow’:
../../../src/filemanager/dir.c:263:14: warning: declaration of ‘clear’ shadows a global declaration [-Wshadow]

Attachments

mc-3539-fix-gcc46-warning.patch​ (1.9 KB) - added by and 9 years ago.

Change History

Changed 9 years ago by and

comment:1 Changed 9 years ago by and

patch fix reported -Wshadow warning with gcc 4.6.x (this not occur with gcc 4.7 or higher)

patch against 52fd328042a426e885da891c8ce8218cda3a1cf7
compile test with GCC 4.6.4

comment:2 Changed 9 years ago by andrew_b

  • Blocked By 3420 added

comment:3 Changed 9 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed

Thanks! Implemented as [b457921fda7d1c4a6c7f2487c7ad2cb38cc28002].

comment:4 Changed 9 years ago by andrew_b

  • Votes for changeset set to committed-master

comment:5 Changed 9 years ago by andrew_b

  • Blocked By 3420 removed
Note: See TracTickets for help on using tickets.