Ticket #3537 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

isofs doesn't show .dotfiles

Reported by: vda Owned by: zaytsev
Priority: major Milestone: 4.8.16
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking: #2851
Branch state: merged Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

There appears to be an easy bug in iso9660 helper:

if (name ~ /^\.\.?/) next

means "skip all lines which start with one or two dots".
Author probably meant: if (name ~ /^\.\.?$/) next

I propose to not be cryptic and just check both possibilities separately.

The below trivial patch was tested to work: now I see
the file named ".dot" in a test iso file.

(Note: there seems to be another bug: SEMICOLON = "YES"
is not a correct comparison (should use ==),
it's assignment! As a result, sub(";1$", "", name);
is always executed).

Attachments

0001-iso9660-dotfiles.patch (1.1 KB) - added by vda 4 years ago.
patch
0001-isofs-fix-incorrect-awk-comparison-operator.patch (1.0 KB) - added by vda 4 years ago.
SEMICOLON == "YES" fix

Change History

Changed 4 years ago by vda

patch

comment:1 Changed 4 years ago by andrew_b

  • Component changed from mc-core to mc-vfs
  • Description modified (diff)

comment:2 Changed 4 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Branch state changed from no branch to on hold
  • Milestone changed from Future Releases to 4.8.15

Branch: 3537_isofs_dotfiles.
Changeset: [e591862f219f7d8d11cacc894aa80f7b9fc18960].

Denys, could you please be so kind as to make a "SEMICOLON = "YES"" patch, so that we can close everything in one go? Thanks!

Changed 4 years ago by vda

SEMICOLON == "YES" fix

comment:3 Changed 4 years ago by vda

The SEMICOLON == "YES" patch is technically correct, but if, say, SEMICOLON="YES" isn't set correctly somewhere (imagine another bug), the result of this patch may be that isofs would start showing files with FILE;N suffixes.

comment:4 Changed 4 years ago by zaytsev

Apparently introduced in #2471.

comment:5 Changed 4 years ago by zaytsev

May be related to #2851.

comment:6 Changed 4 years ago by andrew_b

  • Milestone changed from 4.8.15 to 4.8.16

comment:7 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on hold to approved

comment:8 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [24d09babd8d60946217d4eeede5769c9a7d4b282].

git log --pretty=oneline 2540595..24d09ba

comment:9 Changed 4 years ago by andrew_b

  • Status changed from testing to closed

comment:10 Changed 4 years ago by zaytsev

  • Blocking 2851 added
Note: See TracTickets for help on using tickets.