Ticket #2122 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Y2k bug in uzip vfs

Reported by: AndrewFilonov Owned by: slavazanko
Priority: minor Milestone: 4.7.2
Component: mc-vfs Version: master
Keywords: unzip Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

Newest version of unzip returns year of file with 4 digits.
But regexp in uzip checks only 2 digits.

Attachments

uzip.in (607 bytes) - added by AndrewFilonov 9 years ago.
Small fix for this bug
uzip.diff (525 bytes) - added by AndrewFilonov 9 years ago.
Another side of this bug, missed before

Change History

Changed 9 years ago by AndrewFilonov

Small fix for this bug

comment:1 Changed 9 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko
  • Version changed from version not selected to master

comment:2 Changed 9 years ago by slavazanko

  • Priority changed from major to minor
  • Keywords unzip added
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.2

Created branch 2122_y2k_bug_in_zip.

Initial changeset: 20575074d5450b3cfe072bb8d8666f713af6d00e

Please review.

comment:3 Changed 9 years ago by AndrewFilonov

Why you don't want to use simpliest regexp?

Changed 9 years ago by AndrewFilonov

Another side of this bug, missed before

comment:4 follow-up: ↓ 5 Changed 9 years ago by slavazanko

Why you don't want to use simpliest regexp?

IMHO, looks like more accuracy.

Another side of this bug, missed before

comment:5 in reply to: ↑ 4 Changed 9 years ago by AndrewFilonov

IMHO, looks like more accuracy.

IMHO looks like slow Y10K bug realization.

comment:6 follow-up: ↓ 7 Changed 9 years ago by slavazanko

IMHO looks like slow Y10K bug realization.

Do you insist on your variant? And why if yes (slower - what else?)

P.S. This is not a holywar - I just asked you.

comment:7 in reply to: ↑ 6 Changed 9 years ago by AndrewFilonov

Do you insist on your variant? And why if yes (slower - what else?)

This is good example for KISS principle.

comment:8 Changed 9 years ago by slavazanko

This is good example for KISS principle.

changeset:657c8d9ba47c0a484ae4cec399b32df47194ea19

comment:9 Changed 9 years ago by AndrewFilonov

  • Owner changed from slavazanko to AndrewFilonov

All ok now

comment:10 Changed 9 years ago by andrew_b

  • Owner changed from AndrewFilonov to slavazanko
  • Status changed from accepted to assigned
  • Votes for changeset set to andrew_b

comment:11 Changed 9 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • severity changed from on review to approved

comment:12 Changed 9 years ago by slavazanko

  • Status changed from assigned to testing
  • Votes for changeset changed from andrew_b angel_il to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:13 Changed 9 years ago by slavazanko

  • Status changed from testing to closed
  • Votes for changeset changed from commited-master to committed-master committed-stable
Note: See TracTickets for help on using tickets.