Ticket #2114 (closed defect: fixed)

Opened 15 years ago

Last modified 15 years ago

Don't treat files ending with a dot as gzip

Reported by: tomj Owned by: andrew_b
Priority: trivial Milestone: 4.7.2
Component: mc-core Version: 4.7.0.2
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

Hello,

after upgrading from mc 4.6.x to mc-4.7.0.2, I was unable
to view the email files of the cyrus IMAP server.
The file name is always "##NUMBER##.".

It turned out the gzip regex always matched
for files ending in a dot. Attached patch fixes the issue.

Cheers,
Thomas

Attachments

mc-dont-treat-files-ending-with-dot-as-gzip.patch​ (397 bytes) - added by tomj 15 years ago.

Change History

Changed 15 years ago by tomj

comment:1 Changed 15 years ago by andrew_b

Thanks!

I guess, the same bug is in 633 line

regex/\.bz2?$
        View=%view{ascii} bzip2 -dc %f 2>/dev/null

comment:2 Changed 15 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • severity changed from no branch to on review
  • Keywords stable-candidate added

Created 2114_gz_z_bz2_extension branch. Parent branch is master.
changeset:2c0e182ae905a68b3f86b59cac2b005d1189fb8f

comment:3 Changed 15 years ago by tomj

I guess the bz2 line is ok, as it matches ".bz2" and ".bz".

comment:4 Changed 15 years ago by andrew_b

Regexp was bz2?$. So it not matched bz, but matched bz2p, bz28, bz2-, etc.

comment:5 Changed 15 years ago by ossi

you are confusing regexps with wildcards.

comment:6 Changed 15 years ago by andrew_b

Ah, really...

Created branch 2114_gz_z_bz2_extension.
changeset:b8242d0deb70ecd05338086d3983cd985b5d7c83

comment:7 Changed 15 years ago by angel_il

  • Votes for changeset set to angel_il

comment:8 Changed 15 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b
  • severity changed from on review to approved

comment:9 Changed 15 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b to commited-master commited-stable
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:7e427c2cfafc7b642afa3f2d5d875723d48ec5d5

Cherry-picked to 4.7.0-stable
changeset:0932211e05c35c5c7a881fd8c72f02d667866df9

comment:10 Changed 15 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Milestone changed from 4.7 to 4.7.2
Note: See TracTickets for help on using tickets.