Ticket #155 (closed enhancement: fixed)
savannah: Remove of WANT_WIDGETS
Reported by: | andrew_b | Owned by: | metux |
---|---|---|---|
Priority: | minor | Milestone: | 4.7 |
Component: | mc-core | Version: | 4.6.1 |
Keywords: | committed-master | Cc: | |
Blocked By: | Blocking: | ||
Branch state: | Votes for changeset: |
Description (last modified by metux) (diff)
My old patch: remove of WANT_WIDGETS preprocessor directives.
Original: http://savannah.gnu.org/patch/?6267
Submitted by: | Andrew Borodin <a_borodin> | Submitted on: | Wed 14 Nov 2007 07:00:13 AM UTC |
Category: | Core | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Discussion:
Wed 14 Nov 2007 07:00:13 AM UTC, original submission: What the WANT_WIDGETS define is need for? I propose to remove WANT_WIDGETS at all. Patch is attached. Changelog: src/main.h: Remove #ifdef WANT_WIDGETS preprocessor directive. src/filegui.c: Remove #define WANT_WIDGETS preprocessor directive. src/layout.c: Likewise. src/screen.c: Likewise.
Committed to master: change:f516d1c1d14e5528715226cd022cd5af17d29fce
Attachments
Change History
Changed 16 years ago by slavazanko
- Attachment mc-20071103-want_widgets.patch added
Changed 16 years ago by slavazanko
- Attachment 155_remove_WANT_WIDGETS-rev1.patch added
reworked patch for git
comment:2 Changed 16 years ago by slavazanko
- Status changed from new to accepted
- Owner set to slavazanko
- Milestone changed from 4.6.2 to 4.7
Branch '155_remove_WANT_WIDGETS' created.
Now need to initiate vote.
comment:4 Changed 16 years ago by winnie
- Keywords review, vote-winnie added; review removed
Hey,
As there is really no configure check for something I think we can safely remove this stuff as Pavel Roskin started to do this in 2005. (See 446c06ea0c6e5bcd107a94399c13affe8a2dfe38).
Therefore a vote from me.
Greetings
comment:5 Changed 16 years ago by slavazanko
It's not my patch, I'm only little rework it for resolve one conflict... But as fact, I'm patch-attacher... and I don't know, valid my vote, or no...
comment:6 Changed 16 years ago by anonymous
this patch moves out the main widget definitions to their own .h files and include it only where WANT_WIDGETS was defined
comment:10 Changed 16 years ago by slavazanko
@slavo: for which revision is your vote ?
want-widgets.001.diff
Different .h-files more clean idea that previous ideas in patches (mc-20071103-want_widgets.patch or 155_remove_WANT_WIDGETS-rev1.patch)
comment:12 Changed 16 years ago by metux
- Keywords committed-master added; approved removed
- Description modified (diff)
comment:13 Changed 16 years ago by metux
- Status changed from accepted to testing
- Keywords vote-winnie vote-slavazanko removed
- Resolution set to fixed
Original patch from savannah. Added by a_borodin