Ticket #155 (closed enhancement: fixed)

Opened 10 years ago

Last modified 9 years ago

savannah: Remove of WANT_WIDGETS

Reported by: andrew_b Owned by: metux
Priority: minor Milestone: 4.7
Component: mc-core Version: 4.6.1
Keywords: committed-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

My old patch: remove of WANT_WIDGETS preprocessor directives.

Original: http://savannah.gnu.org/patch/?6267

Submitted by:Andrew Borodin <a_borodin>Submitted on:Wed 14 Nov 2007 07:00:13 AM UTC
Category:CorePriority:5 - Normal
Status:NonePrivacy:Public
Assigned to:NoneOpen/Closed:Open

Discussion:

Wed 14 Nov 2007 07:00:13 AM UTC, original submission:

What the WANT_WIDGETS define is need for? I propose to remove 
WANT_WIDGETS at all. Patch is attached.

Changelog:

src/main.h: Remove #ifdef WANT_WIDGETS preprocessor directive.
src/filegui.c: Remove #define WANT_WIDGETS preprocessor directive.
src/layout.c: Likewise.
src/screen.c: Likewise.

Committed to master: change:f516d1c1d14e5528715226cd022cd5af17d29fce

Attachments

mc-20071103-want_widgets.patch (1.7 KB) - added by slavazanko 10 years ago.
Original patch from savannah. Added by a_borodin
155_remove_WANT_WIDGETS-rev1.patch (1.5 KB) - added by slavazanko 10 years ago.
reworked patch for git
want-widgets.001.diff (2.4 KB) - added by anonymous 10 years ago.
Added by email2trac

Change History

Changed 10 years ago by slavazanko

Original patch from savannah. Added by a_borodin

comment:1 Changed 10 years ago by slavazanko

  • Description modified (diff)

Changed 10 years ago by slavazanko

reworked patch for git

comment:2 Changed 10 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko
  • Milestone changed from 4.6.2 to 4.7

Branch '155_remove_WANT_WIDGETS' created.

Now need to initiate vote.

comment:3 Changed 10 years ago by slavazanko

  • Type changed from defect to enhancement

comment:4 Changed 10 years ago by winnie

  • Keywords review, vote-winnie added; review removed

Hey,

As there is really no configure check for something I think we can safely remove this stuff as Pavel Roskin started to do this in 2005. (See 446c06ea0c6e5bcd107a94399c13affe8a2dfe38).

Therefore a vote from me.

Greetings

comment:5 Changed 10 years ago by slavazanko

It's not my patch, I'm only little rework it for resolve one conflict... But as fact, I'm patch-attacher... and I don't know, valid my vote, or no...

Changed 10 years ago by anonymous

Added by email2trac

comment:6 Changed 10 years ago by anonymous

this patch moves out the main widget definitions to their own .h files and include it only where WANT_WIDGETS was defined

comment:7 Changed 10 years ago by metux

  • Owner changed from slavazanko to metux

comment:8 Changed 10 years ago by slavazanko

  • Keywords review vote-slavazanko added; review, removed

comment:9 Changed 10 years ago by metux

@slavo: for which revision is your vote ?

comment:10 Changed 10 years ago by slavazanko

@slavo: for which revision is your vote ?

want-widgets.001.diff

Different .h-files more clean idea that previous ideas in patches (mc-20071103-want_widgets.patch or 155_remove_WANT_WIDGETS-rev1.patch)

comment:11 Changed 10 years ago by metux

  • Keywords approved added; review removed

comment:12 Changed 10 years ago by metux

  • Keywords committed-master added; approved removed
  • Description modified (diff)

comment:13 Changed 10 years ago by metux

  • Status changed from accepted to testing
  • Keywords vote-winnie vote-slavazanko removed
  • Resolution set to fixed

comment:14 Changed 10 years ago by winnie

  • Status changed from testing to closed

comment:15 Changed 10 years ago by sunrise1

  • severity set to no branch
Note: See TracTickets for help on using tickets.