Ticket #1400 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Broken tab order in copy dialog

Reported by: zaytsev Owned by:
Priority: major Milestone: 4.7.0-pre3
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

Press F5. Now TAB x 3. Expected result: "to:" edit box focused. Current git: "[ ] follow Links".

Change History

comment:1 Changed 10 years ago by angel_il

  • Version changed from 4.6.2 to master
  • Milestone changed from 4.7.0-pre1 to 4.7.0-pre2

comment:2 Changed 10 years ago by styx

IMHO 'source mask' edit box and 'to' edit box should exchange their position.
Then moving logic will be good, and we still have fast access to the 'source mask' edit box.

comment:3 Changed 10 years ago by zaytsev

I don't really appreciate this idea, because the From --> To order seems to be most logical to me and I like how the To: edit box is currently highlighted when you first hit F5 or F6. I just happen to dislike the moving order problems it introduces. I don't see how the fact that the box has focus relates to the tab order.

But generally speaking I hardly use the From: box at all, so if there is no way to fix the tab order only, swapping the boxes is OK with me.

comment:4 Changed 10 years ago by angel_il

  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

comment:5 Changed 10 years ago by slavazanko

  • Blocked By 1562 added

comment:6 Changed 10 years ago by andrew_b

  • Blocked By 1562 removed

(In #1562) Merged to master.
Initial changeset:f9d6bb075c9cbed89aba9f6e3a201b32e0786399
Final changeset:c057b0a02a69c69ad528ab267bd140d4bef3f358

git log --pretty=oneline 44a094c..bf7b330

comment:7 Changed 10 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed

The order of widgets in copy/move dialog have been fixed in #1562.

Note: See TracTickets for help on using tickets.