Ticket #93 (closed defect: wontfix)

Opened 16 years ago

Last modified 5 years ago

cons.saver: open the console in non-blocking mode

Reported by: slavazanko Owned by:
Priority: major Milestone:
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

Source: Gentoo Portage
Reference: 4.6.1
Submit-By: Enrico Weigelt, metux IT service <weigelt metux de>
Submit-Date: 2008-12-26
State: new

See attachment.

Attachments

cons_nonblock.patch​ (669 bytes) - added by slavazanko 16 years ago.

Change History

Changed 16 years ago by slavazanko

comment:1 Changed 16 years ago by metux

Comment from Miguel (on the list):

Opening the console in non-blocking mode is a bad idea,
as it means that every call that is done later on the
console_fd needs to check for EWOULDBLOCK. Most of the time,
it would be not return that, it would only return that under
unique situations which means that testing this patch would
not only be non-trivial, but someone would have to audit
all the code paths.

Also, this is lacking a ChangeLog? explaining why this is needed.

But I think that this patch should not be applied, it seems
like a workaround that has not been properly implemented.

comment:2 Changed 16 years ago by styx

  • Milestone set to future releases

comment:3 Changed 15 years ago by ossi

  • severity set to no branch

the need for this should be clarified, otherwise it should be rejected.

comment:4 Changed 11 years ago by ossi

  • Branch state set to no branch

timeout. reject.

comment:5 Changed 5 years ago by metux

Did anybody find out why Gentoo folks applied that patch ?
Back 11 years ago, I just forwarded this as I found that patch in portage tree.

I believe we can close this bug.

comment:6 Changed 5 years ago by andrew_b

  • Status changed from new to closed
  • Version set to master
  • Resolution set to wontfix
  • Milestone Future Releases deleted
Note: See TracTickets for help on using tickets.