Ticket #65 (closed enhancement: fixed)

Opened 10 years ago

Last modified 5 years ago

savannah: Pascal syntax highlighting update

Reported by: dvh Owned by: winnie
Priority: minor Milestone: 4.6.2
Component: mc-core Version:
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset:

Description (last modified by ossi) (diff)

Original: http://savannah.gnu.org/bugs/?19361

Submitted by:Dusan Halicky <dvh>Submitted on:Tue 20 Mar 2007 07:14:19 PM UTC
Category:NoneSeverity:3 - Normal
Status:NonePrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:older than 4.5.55Operating System:GNU/Hurd

Original submission:

There are missing keywords: finalization, read, write, overload, so 
please add following lines to pascal syntax:

keyword whole finalization white
keyword whole overload white
keyword whole read white
keyword whole write white

Thanks.

Comment 1 by Pavel Tsekov <ptsekov> at Thu 26 Apr 2007 04:42:49 PM UTC:

Any reason not to add this ? Do we have any pascal coders around 
since I really don't know what this keywords do neither if they are 
standard.

Attachments

additional_pascal_keywords.patch (1.4 KB) - added by winnie 10 years ago.
Add the missing pascal keywords (diffed against git master)
additional_pascal_keywords-rev2.patch (1.5 KB) - added by slavazanko 10 years ago.
added 'writeln' keyword highlighting

Change History

comment:1 Changed 10 years ago by metux

A patch against current 4.6.1 would be fine :)

comment:2 Changed 10 years ago by winnie

  • Status changed from new to accepted
  • Owner set to winnie
  • Priority changed from major to minor

Okay, I checked it:

write, read, overload and finalization are valid pascal keywords. I'm creating a patch right now.

Changed 10 years ago by winnie

Add the missing pascal keywords (diffed against git master)

Changed 10 years ago by slavazanko

added 'writeln' keyword highlighting

comment:3 Changed 10 years ago by winnie

  • Milestone set to 4.6.2

rev2 seems to be okay for me, therefore:

+1 for rev2

Setting Milestone to 4.6.2 as this is very trivial and should be fixed within the next release.

comment:4 Changed 10 years ago by metux

If it's committed, should this ticket be closed ?

comment:5 Changed 10 years ago by slavazanko

Only accepter or ticket-starter (if developer) may apply patch. For now ticket accepted to 'winnie', but you may accept yourself (and write reason).

This patch will applyed only after 2 votes of developers (now only 1 vote - by Winnie, vote of pather (my) don't accepted).

If any other developer will vote to this patch too (additional_pascal_keywords-rev2.patch) - patch will apply to a 'master' branch; state of ticket will change to 'testing stage'.

After applying patch will need write comment to this ticket with a link to revision contains this patch.

I think, this must be rules for all tickets.

comment:6 Changed 10 years ago by Enrico Weigelt

For what language specification is this patch ?

Back from my old pascal times (about 10yrs ago), there was neither
anything like finalisation nor overloading. (read|write)(ln|) always
have been normal functions, just Borland broke the standard by
adding some compiler magic, IMHO ...

cu

comment:7 Changed 10 years ago by Patrick Winnertz

Hey,
finalization is a keyword from delphi to be honest. So yes.. this is a addition
which was done more or less by Borland.. overloading also...

I think we also should add keywords from delphi and freepascal to this file..
Is this okay?

Greetings
Winnie

comment:8 Changed 10 years ago by slavazanko

I think we also should add keywords from delphi and freepascal to this file..

Just add those keywords and attach new patch (you may make new branch).

Is this okay?

Any idea okay, IMHO :)

comment:9 Changed 10 years ago by winnie

  • Status changed from accepted to testing
  • Keywords preview added
  • Resolution set to fixed

comment:10 Changed 10 years ago by metux

  • Keywords review vote-metux added; preview removed

comment:11 Changed 10 years ago by slavazanko

  • Keywords vote-metux, vote-slavaz added; vote-metux removed

comment:12 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko added; vote-slavaz removed

comment:13 Changed 10 years ago by winnie

  • Keywords vote-metux approved added; vote-metux, removed

Add approved keyword as 2 people have voted.

comment:14 Changed 10 years ago by winnie

  • Status changed from testing to closed

Merged into mc-4.6 and master.. therefore closing now

comment:15 Changed 5 years ago by ossi

  • Description modified (diff)
  • Branch state set to no branch
  • Reporter changed from slavazanko to dvh

comment:16 Changed 5 years ago by andrew_b

  • Keywords review vote-metux vote-slavazanko approved removed
  • Branch state changed from no branch to merged
Note: See TracTickets for help on using tickets.