savannah: Pascal syntax highlighting update

[dvh]

Original: ​http://savannah.gnu.org/bugs/?19361

Submitted by:	Dusan Halicky <dvh>	Submitted on:	Tue 20 Mar 2007 07:14:19 PM UTC
Category:	None	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	older than 4.5.55	Operating System:	GNU/Hurd

Original submission:

There are missing keywords: finalization, read, write, overload, so 
please add following lines to pascal syntax:

keyword whole finalization white
keyword whole overload white
keyword whole read white
keyword whole write white

Thanks.

Comment 1 by Pavel Tsekov <ptsekov> at Thu 26 Apr 2007 04:42:49 PM UTC:

Any reason not to add this ? Do we have any pascal coders around 
since I really don't know what this keywords do neither if they are 
standard.

[metux]

A patch against current 4.6.1 would be fine :)

[winnie]

Okay, I checked it:

write, read, overload and finalization are valid pascal keywords. I'm creating a patch right now.

[winnie]

Add the missing pascal keywords (diffed against git master)

[slavazanko]

added 'writeln' keyword highlighting

[winnie]

rev2 seems to be okay for me, therefore:

+1 for rev2

Setting Milestone to 4.6.2 as this is very trivial and should be fixed within the next release.

[metux]

If it's committed, should this ticket be closed ?

[slavazanko]

Only accepter or ticket-starter (if developer) may apply patch. For now ticket accepted to 'winnie', but you may accept yourself (and write reason).

This patch will applyed only after 2 votes of developers (now only 1 vote - by Winnie, vote of pather (my) don't accepted).

If any other developer will vote to this patch too (additional_pascal_keywords-rev2.patch) - patch will apply to a 'master' branch; state of ticket will change to 'testing stage'.

After applying patch will need write comment to this ticket with a link to revision contains this patch.

I think, this must be rules for all tickets.

[Enrico Weigelt]

For what language specification is this patch ?

Back from my old pascal times (about 10yrs ago), there was neither
anything like finalisation nor overloading. (read|write)(ln|) always
have been normal functions, just Borland broke the standard by
adding some compiler magic, IMHO ...

cu

[Patrick Winnertz]

Hey,
finalization is a keyword from delphi to be honest. So yes.. this is a addition
which was done more or less by Borland.. overloading also...

I think we also should add keywords from delphi and freepascal to this file..
Is this okay?

Greetings
Winnie

[slavazanko]

I think we also should add keywords from delphi and freepascal to this file..

Just add those keywords and attach new patch (you may make new branch).

Is this okay?

Any idea okay, IMHO :)

[winnie]

Add approved keyword as 2 people have voted.

[winnie]

Merged into mc-4.6 and master.. therefore closing now