version.sh fixes

[ossi]

Tip: changeset:22ca1a9263d77303cc78518d40e55bd3571918ad
Start: changeset:9a5c9cbc8898a80a82705aacc5be9c5866722b35

git log 22ca1a926^..22ca1a926

[slyfox]

0001-remove-useless-commands-which-also-happen-to-be-bash.patch

All patches look good except the first. It seems to break out-of-tree build. version.h must be updated in source tree even if configure is ran in another directory.

--git-dir might be needed

Mind to try 'git send-email' to mc-bugs@ as a followup to #403 ?
(Message-ID: <042.8aa6aaeb3f2833074e5b63f4e6b7dab8@…>)

[slyfox]

--git-dir might be needed

or plain old_pwd="$PWD"; cd "${top_src_dir}"; ... cd "$old_pwd"

[iNode]

About first patch:
pushd and popd does not work in zsh, maybe just remember pwd and return when you need?

[ossi]

Replying to slyfox:

It seems to break out-of-tree build. version.h must be updated in source tree even if configure is ran in another directory.

whoops, the directory name "maint" triggered an "irrelevant for usual builds" switch in me.

--git-dir might be needed

indeed. patches following ...

Mind to try 'git send-email' to mc-bugs@ as a followup to #403 ?

i miss the point of the exercise ...

[ossi]

replace previous 0002

[ossi]

replace first 0001

[slyfox]

Pulled all patches and fixed actual version.h regeneration.
Added forced version.h generation in autogen.sh to avoid double
./configure start in clean envoronment (related to #411)

Branch: 403_versioning_cleanup
Start changeset:9a5c9cbc8898a80a82705aacc5be9c5866722b35
Tip changeset:eea108377d76d7855c25270c2551019098f46070
{{
git log 3337c39..eea10837
}}

[slyfox]

(In #411) #403 touches this issue in some places:

• non-bash fixes
• version.h pregeneration

[slavazanko]

Looks good.