Ticket #402 (closed defect: fixed)
Code page is changed when cancelling codepage selection
| Reported by: | styx | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7 |
| Component: | mc-core | Version: | master |
| Keywords: | commited-master | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description
- Select file and press F3
- Select code page Windows 1251 and press Enter
- Press F3
- Press F3 again
- Select code page Windows 1251 and press Esc 2 times
In the result we have file view with changed codepage
Change History
comment:1 Changed 15 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
comment:3 follow-up: ↓ 4 Changed 15 years ago by angel_il
i think need replace this
51 /* Return value:
52 * -2 : Cancel
53 * -1 : "Other 8 bit" if seldisplay == TRUE
54 * -1 : "No translation" if seldisplay == FALSE
55 * >= 0 : charset number
56 */
to const
comment:4 in reply to: ↑ 3 Changed 15 years ago by andrew_b
Replying to angel_il:
to const
Done.
Rebased to master.
changeset:205fa24e7dd8813f0f4cdfdb04ed933982639422
comment:5 follow-up: ↓ 7 Changed 15 years ago by angel_il
1) have any ascii file
2) F4
3) Ctrl-T and select < No translation >
4) see only dots like this
.............. .......................... ....................... }} its correct?! i think no!
comment:6 Changed 15 years ago by angel_il
.............. .......................... .......................
its correct?!
i think no!
comment:7 in reply to: ↑ 5 ; follow-up: ↓ 8 Changed 15 years ago by andrew_b
Replying to angel_il:
1) have any ascii file
Any ASCII file? Very strange. I cannot confirm that. In 8-bit locale works as expected.
Ok, I'll test this branch in UTF-8 locale.
comment:8 in reply to: ↑ 7 Changed 15 years ago by andrew_b
Fixed in changeset:efbbd3883f2f054466cc797ff44dc818eabe8a6b
Please, review and vote.
comment:12 follow-up: ↓ 14 Changed 15 years ago by andrew_b
- Keywords commited-master added; vote-slavazanko vote-iNode vote-styx approved removed
- Status changed from accepted to testing
- Resolution set to fixed
Merged to master.
Start changeset:205fa24e7dd8813f0f4cdfdb04ed933982639422
End charset:537bc710690e2ab7f6c02449e9d6b1a5347c58d3
git log --pretty=oneline 205fa24^..537bc71
comment:14 in reply to: ↑ 12 Changed 15 years ago by andrew_b
Sorry for end changeset error.
Start changeset:205fa24e7dd8813f0f4cdfdb04ed933982639422
End changeset:537bc710690e2ab7f6c02449e9d6b1a5347c58d3
git log --pretty=oneline 205fa24^..537bc71
402_select_codepage branch is created. Parent branch: master.
Initial changeset:108886f3e95d484f0150b19a6e2ad7a2de051c36