Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] mcedit: codejump dialog jumps wrong. #3698

Closed
mc-butler opened this issue Oct 8, 2016 · 6 comments
Closed

[patch] mcedit: codejump dialog jumps wrong. #3698

mc-butler opened this issue Oct 8, 2016 · 6 comments
Assignees
@zyv
Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress ver: 4.8.18 Reproducible in version 4.8.18
Milestone
4.8.19

Comments

@mc-butler
Copy link

Important

This issue was migrated from Trac:

Origin https://midnight-commander.org/ticket/3698
Reporter rimf (rimf@….ru)
Keywords codejump, ctags, etags

I create TAGS file with command:
$ find . -type f -name "*.[ch]" | ctags --c-kinds=+p --fields=+iaS --extra=+q -e -L-

My quick fix patch attached.

Note

Original attachments:
@mc-butler
Copy link
Author

Changed by rimf (rimf@….ru) on Oct 8, 2016 at 0:44 UTC

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 8, 2016 at 9:26 UTC (comment 1)

  • Branch state changed from no branch to on review
  • Owner set to zaytsev
  • Cc set to andrew_b
  • Milestone changed from Future Releases to 4.8.19
  • Status changed from new to accepted

Branch: 3698_etags_codejump
Changeset: [224f535]

Roman, thanks for the clean patch! How about writing some tests for the parser ;-) ? I can understand if that's too much for you.

Andrew, could you please approve? I've investigated what caused the problem (see commit message) and it looks legit.

@mc-butler
Copy link
Author

Changed by rimf (rimf@….ru) on Oct 8, 2016 at 11:57 UTC (comment 2)

Thank you. Now I can do only reports on bugs.

@mc-butler
Copy link
Author

Changed by andrew_b (@aborodin) on Oct 8, 2016 at 14:29 UTC (comment 3)

  • Cc andrew_b deleted
  • Votes set to andrew_b
  • Branch state changed from on review to approved

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 8, 2016 at 14:39 UTC (comment 4)

  • Resolution set to fixed
  • Status changed from accepted to testing
  • Branch state changed from approved to merged
  • Votes changed from andrew_b to committed-master

Merged to master: [85a28f1]. Thank you!

@mc-butler
Copy link
Author

Changed by zaytsev (@zyv) on Oct 10, 2016 at 19:31 UTC (comment 5)

  • Status changed from testing to closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zyv zyv

Labels
area: mcedit mcedit, the built-in text editor prio: medium Has the potential to affect progress ver: 4.8.18 Reproducible in version 4.8.18
Milestone
4.8.19
Development

No branches or pull requests
2 participants
@zyv @mc-butler