Ticket #3607 (closed task: fixed)
Prepare for release mc-4.8.17
Reported by: | zaytsev | Owned by: | zaytsev |
---|---|---|---|
Priority: | major | Milestone: | 4.8.17 |
Component: | adm | Version: | master |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | merged | Votes for changeset: | committed-master |
Description
See wiki:ReleaseGuidelines for more details.
Attachments
Change History
Changed 8 years ago by and
- Attachment mc-3607-widget-dialog.c-Make-Solaris-Studio-happy.patch added
Changed 8 years ago by mooffie
comment:3 Changed 8 years ago by mooffie
(As for the patch I've just attached (S-Lang title at configure's summary): it's a little silly to have the duplicate "library" word in "Screen library: S-Lang library" and "Screen library: Ncurses library". If you want me to remove the second "library" word, let me know.)
comment:4 Changed 8 years ago by andrew_b
mc-3607-args.c-Make-solaris-studio-happy.patch: applied.
mc-3607-widget-dialog.c-Make-Solaris-Studio-happy.patch: applied.
mc-3607-configure-summary-omits-S-Lang-when-used-as-screen-library.patch: applied.
Text of screen_msg was fixed in separate commit.
comment:5 Changed 8 years ago by and
Hi Andrew, Yuri,
I setup a Open Build Service testing for mc at build.opensuse.org
https://build.opensuse.org/package/show/home:andreasmohr:mc/mc-git_master-ncurses
(SuSE/RedHat spec/rpm and Arch/pkgbuild was easy mode but depian drying old build concept is nappy)
As first step I choose explicit ncurses+libssh2+libgpm+enable-werror
and take git(hub) master source.
fun fact, older(!) gcc version (RHEL6) inform us about:
[ 130s] widget-common.c: In function 'mouse_get_local': [ 130s] widget-common.c:369: error: 'local.margin' is used uninitialized in this function [-Wuninitialized] [ 130s] widget-common.c:369: error: 'local.clicks' is used uninitialized in this function [-Wuninitialized] [ 130s] widget-common.c:369: error: 'local.vc' is used uninitialized in this function [-Wuninitialized]
I will create more build tests (slang,minimal,different git brand source?).
Let me know, what should be next and for interest.
Changed 8 years ago by and
- Attachment mc-3607-widget-common.c-Cleanup-uninitialized-warning.patch added
comment:6 Changed 8 years ago by and
I have rework package naming for better future permutation testing.
https://build.opensuse.org/project/show/home:andreasmohr:mc
comment:7 Changed 8 years ago by and
Consider to take #3598 into this cleanup round and skip all g_strdup patches for now.
Changed 8 years ago by and
- Attachment mc-3607-cppcheck-Cleanup-Passing-NULL-after-the-last-warning.patch added
comment:8 Changed 8 years ago by andrew_b
mc-3607-widget-common.c-Cleanup-uninitialized-warning.patch: applied.
mc-3607-cppcheck-Cleanup-Passing-NULL-after-the-last-warning.patch: applied.
comment:9 follow-up: ↓ 10 Changed 8 years ago by mooffie
Commit "(input_is_empty): new WInput API" has a mistake:
In input_is_empty(), it should be "== '\0'", not "!= '\0'".
comment:10 in reply to: ↑ 9 Changed 8 years ago by andrew_b
Replying to mooffie:
Commit "(input_is_empty): new WInput API" has a mistake:
In input_is_empty(), it should be "== '\0'", not "!= '\0'".
Fixed. Thanks.
The code in input_is_empty() is overcareful, but let it be.
comment:11 Changed 8 years ago by andrew_b
mc-3607-Remove-orphaned-be-tarask.po_-file.patch: applied.
comment:12 Changed 8 years ago by andrew_b
mc-3607-cleanup-cppcheck-warning-at-direntry.patch: applied.
mc-3607-cleanup-cppcheck-warning-at-layout.patch: applied.
mc-3607-cleanup-cppcheck-warning-at-utilunix.patch: applied.
Changed 8 years ago by and
- Attachment mc-3607-Cleanup-cppcheck-warning-at-input_complete.patch added
comment:13 Changed 8 years ago by andrew_b
3607-Cleanup-cppcheck-warning-at-input_complete.patch: applied.
comment:14 follow-up: ↓ 15 Changed 8 years ago by zaytsev-work
Hi Andrew, would you be so kind as to rebase against master? I'll try my best to have a deeper look during the weekend, as discussed. Thanks!
comment:15 in reply to: ↑ 14 Changed 8 years ago by andrew_b
Done.
Initial changeset:2f3a10ece140acaa196280db144ae9bb00b26b53
comment:16 Changed 8 years ago by zaytsev
Sync with gnulib just caused:
../../../lib/strutil/xstrtol.c: In function ‘xstrtoumax’: ../../../lib/strutil/xstrtol.c:145:9: error: switch missing default case [-Werror=switch-default]
comment:18 Changed 8 years ago by zaytsev
- Status changed from new to accepted
- Owner set to zaytsev
- Branch state changed from on review to approved
I've looked at the patches, and it seems reasonable. Too bad we don't have a robust safety net for refactorings as in [52263429b3601272ec255f7568ec2e5b0f18ee48]. Apart from that, I've applied the last patch by Andreas, and added a few file formats to filehighlight.
Are we good to go for the release tomorrow? I will try to have a look at #3130 after lunch.
comment:19 Changed 8 years ago by andrew_b
- Status changed from accepted to testing
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [82fc95fb7744f7d6ff9b5ad9552e5a3d3b9daf12].
git log --pretty=oneline 7fd0f17..82fc95f
comment:21 Changed 8 years ago by zaytsev
- Status changed from closed to reopened
- Resolution fixed deleted
Huh, that's the release ticket, right?
comment:22 Changed 8 years ago by zaytsev
download PO-translations from Transifex.net
done
store translations in git repo
done
download the hint translations from Transifex.net
done
store translations in git repo
not necessary
create new NEWS wiki page for next version with empty template
done (wiki:NEWS-4.8.17)
add content of current NEWS wiki page to the doc/NEWS file
done
create new tag in git
done; not pushed yet
new version in Trac
done
new milestone in Trac
done
create tar.(bz2|xz) package files
done
make checksums for archives
done
upload source packages and checksums to the special upload area
done
comment:25 Changed 8 years ago by zaytsev
- Status changed from reopened to closed
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
developers should download tarballs, verify checksums, compile and install locally
done
upload source packages and checksums ...
done
run command: ...
done
update Wiki start page with latest release number
done
write an announcement: list user visible changes (bugs and features)
done
close current milestone
done
create new ticket (type=task, component=adm) for the next release
done; #3641
close ticket for release
done
Branch: 3607_cleanup.
Initial changeset:636ae35f5cf951f3a160cc8796a95156826acb13