Ticket #3565 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

"External Panelize" dialog should use WListbox's change notification.

Reported by: mooffie Owned by:
Priority: minor Milestone: 4.8.16
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking: #3569
Branch state: merged Votes for changeset: committed-master

Description

Currently it uses a MSG_POST_KEY/MSG_FOCUS hack to achieve this.

Advantage:

We'll get rid of a subtle mouse bug. The use of MSG_FOCUS in the hack inadvertently makes clicking the mouse update the command. But MSG_FOCUS is actually fired before the listbox changes its item, so the command seen is the previously selected (you don't always notice this because WListbox's mouse handler uses MOU_REPEAT, which makes the problem sometime fix itself after a fraction of a second).

Change History

comment:1 Changed 5 years ago by mooffie

Note that after tending to ticket:3566 the code will be tidier:

case MSG_INIT: 
case MSG_NOTIFY:
    update_command ();
    return MSG_HANDLED;

comment:2 Changed 5 years ago by andrew_b

  • Blocking 3569 added

comment:3 Changed 5 years ago by andrew_b

  • Status changed from new to closed
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Branch state changed from no branch to merged
  • Milestone changed from Future Releases to 4.8.16
Note: See TracTickets for help on using tickets.