Ticket #3333 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Error compiling glibcompat.c with glib 2.20.3

Reported by: ginggs Owned by:
Priority: major Milestone: 4.8.14
Component: mc-core Version: 4.8.13
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description

I'm getting the following error while compiling mc 4.8.13 on a system with an old version of glib (2.20.3):

glibcompat.c: In function 'g_error_new_valist':
glibcompat.c:156: error: 'ap' undeclared (first use in this function)
glibcompat.c:156: error: (Each undeclared identifier is reported only once
glibcompat.c:156: error: for each function it appears in.)
glibcompat.c:156: error: 'va_start' used in function with fixed args

Attachments

3333.patch​ (534 bytes) - added by ginggs 10 years ago.
fix g_error_new_valist() in glibcompat.c for glib <2.22.0

Change History

comment:1 Changed 10 years ago by ginggs

  • Summary changed from Error compiling glibcmpat.c with glib 2.20.3 to Error compiling glibcompat.c with glib 2.20.3

Changed 10 years ago by ginggs

fix g_error_new_valist() in glibcompat.c for glib <2.22.0

comment:2 Changed 10 years ago by ginggs

Attached patch works for me.
Compiles OK and running 'mcdiff' with no arguments displays:

Failed to run:
Two files are required to evoke the diffviewer.

comment:3 Changed 10 years ago by andrew_b

  • Blocked By 3265 added
  • Milestone changed from Future Releases to 4.8.14

comment:4 Changed 10 years ago by andrew_b

  • Status changed from new to closed
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Blocked By 3265 removed

Applied as [8c1c48f61ecba5e1ff2f9da0803a3b3ce15ab980].

Note: See TracTickets for help on using tickets.