Ticket #3244 (closed defect: fixed)
viewbold and viewselected missing from some skins
| Reported by: | egmont | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.13 |
| Component: | mc-skin | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | no branch | Votes for changeset: | committed-master |
Description
Some skins (mostly the 256 color ones) lack the viewbold and viewselected definitions.
This results in manual pages not distinguishing bold text from normal, and in hex mode not highlighting the position in the hex table when the cursor is in the right-hand part.
Please see the attached patch that fixes these problems. For viewselected, I took the color from markselect, because it's taken from these in most of the skins.
I made some further minor changes in the skins created by me. I changed "black" and "white" to "rgb000" and "rgb555" when it's rendered in bold, because the legacy 16 colors change their actual color in addition to going bold in most of the terminals which is undesired. Second, there was some unintended difference between the two gray skins in the file type colors.
Attachments
Change History
Changed 10 years ago by egmont
- Attachment mc-3244-viewbold-viewselected-colors.patch added
comment:1 Changed 10 years ago by andrew_b
- Blocked By 3189 added
- Milestone changed from Future Releases to 4.8.13
comment:2 Changed 10 years ago by andrew_b
- Status changed from new to closed
- Votes for changeset set to committed-master
- Resolution set to fixed
Applied as [1aa16a097269e5cbcdf08ac42e517bb903b79348].
Fix skin definitions