Do not link gmodule in if it's not required

[er13]

Two mc-components require gmodule: aspell and textmode_x11_support. If however both are disabled there is no need to link it in.

Might be not that important for desktop-systems... Saves however space and memory on embedded systems.

Attached patch contains a possible solution.

[andrew_b]

Use --as-needed (or something like that if your linker is not GNU ld) in your build system if your don't want link unused libraries.
I hope embedded system developers who use GNU ld as part of their toolchain, use it with --as-needed by default. If not, they should, definitely.

[er13]

Unfortunately using --as-needed globally is not an option because of the need to support older uClibc versions containing "pthread + .so's loaded per dlopen"-bug (one has to link libraries into the main binary in order to get dlopen loaded modules work).

Using it on a per package basis still requires to patch something in the package build system as CFLAGS and LDFLAGS are cached and reused for all packages.

I still consider the patch attached to be the proper way to fix it. It's better fixed in mc as in every embedded build system out there.

Btw. --as-needed is neither in buildroot nor in openwrt used by default.

[gotar]

I'm sharing er13 point of view, that such dependencies should be removed as soon as possible. Decent program should not depend on environment features, especially when solution is so simple and doesn't require maintaince.

[andrew_b]

Branch: 2995_link_gmodule_if_required
changeset:b40a7bcbc7037b596fcfe4a9519e38dce5b0e5dc

[andrew_b]

Merged to master: [5260d6612c6e8f0c46dd89e5abc355d6b1d0a4ee].