Ticket #2941 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

i18n label sizes in learn key dialog

Reported by: dmartina Owned by: andrew_b
Priority: minor Milestone: 4.8.7
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

With latest git sources. Learn keys dialogue shows "smaller buttons" when localized key names include special chars (as the "á" in "Avanzar página" for es_ES locale). "%Ns" formats for g_snprintf are not reliable for multibyte encodings.

I'm providing a patch where padding size is previously computed. For larger buttons (> 16 characters) padding size must be zero.

Attachments

learn.c.diff (871 bytes) - added by dmartina 7 years ago.

Change History

Changed 7 years ago by dmartina

comment:1 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Blocked By 2888 added
  • Keywords i18n removed

comment:2 Changed 7 years ago by andrew_b

Thanks. Applied in 2888_cleanup branch.

comment:3 Changed 7 years ago by andrew_b

  • Blocked By 2888 removed

comment:4 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Branch state changed from no branch to merged

comment:5 Changed 7 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.