Ticket #2808 (closed defect: fixed)

Opened 13 years ago

Last modified 13 years ago

mc 4.8.1.1+ build on FreeBSD 6 fails, patch included

Reported by: phil Owned by: andrew_b
Priority: critical Milestone: 4.8.4
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

In src/filemanager/mountlist.c, sys/param.h needs to be included above any #include <sys/mount.h> on FreeBSD 6, otherwise compiling fails with undefined identifier NGROUPS. Patch attached.

Attachments

mc-freebsd6-mount-h.patch​ (747 bytes) - added by phil 13 years ago.
Simple patch

Change History

Changed 13 years ago by phil

Simple patch

comment:1 Changed 13 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from 4.8 to 4.8.4

Branch: 2808_freebsd6_build_failure (parent: master).
changeset:7c425e85008b0267ff19db8e8119c00e5700ced8

comment:2 Changed 13 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:3 follow-up: ↓ 4 Changed 13 years ago by phil

  • Votes for changeset changed from andrew_b to andrew_b phil

Thanks for committing! I don't exactly understand the lifecycle of changesets in MC development process, but is there a chance it also gets into next stable (4.8.1.x) release?

comment:4 in reply to: ↑ 3 Changed 13 years ago by andrew_b

  • Keywords stable-candidate added
  • Votes for changeset changed from andrew_b phil to andrew_b

Replying to phil:

is there a chance it also gets into next stable (4.8.1.x) release?

Absolutely. I forgot a 'stable-candidate' keyword here.

I've removed your vote since you're the author of the patch. We need vote of another mc developer.

Version 0, edited 13 years ago by andrew_b (next)

comment:5 Changed 13 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • Branch state changed from on review to approved

comment:6 Changed 13 years ago by andrew_b

  • Status changed from accepted to testing
  • Keywords stable-candidate removed
  • Votes for changeset changed from andrew_b slavazanko to committed-master committed-stable
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [7c425e85008b0267ff19db8e8119c00e5700ced8].
Merged to 4.8.1-stable: [fe91533c41ee9f717af57f34f4ca93e7d4e138a6].

comment:7 Changed 13 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.