Ticket #254 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

Copy/Move panel: dest filename not focused

Reported by: egmont Owned by: winnie
Priority: major Milestone: 4.7
Component: mc-core Version: 4.6.2
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: angel_il kdave

Description

A major usability regression is introduced by the (unofficial) UTF-8 patch if mc is compiled with --disable-charset (which is the default).

If you press F5 or F6 to copy or move file(s), it's the "Dive into subdir" toggle that's focused by default, not the destination filename.

Patch attached. Please fix this in the UTF-8 patch. Thanks!

Attachments

00-93-copy-move-dialog-initial-focus.patch (779 bytes) - added by egmont 10 years ago.
The one-line fix for the problem

Change History

Changed 10 years ago by egmont

The one-line fix for the problem

comment:1 Changed 10 years ago by angel_il

  • Keywords vote-angel_il added

comment:2 Changed 10 years ago by kdave

  • Keywords vote-kdave added

comment:3 Changed 10 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted

comment:4 Changed 10 years ago by winnie

  • Owner changed from angel_il to winnie
  • Milestone changed from 4.6.2.1 to UTF8 Support

This also belongs into the utf8 section and not into 4.6.2.1..

comment:5 Changed 10 years ago by egmont

Dear winnie,

Certainly this bug as well as all the other utf8 bugs that I reported belong to the utf8 _section_ (if there was such a field... maybe _component_ but it has no utf8 value), but why the utf8 _milestone_? Maybe I misunderstand what you mean by milestone, but it sounds to me that you've marked the bug as to be addressed whenever mainstream mc is officially going to support to utf8. (Which, according to my knowledge about mc development, is unfortunately quite unlikely to happen in the next few decades.)

Please rest me assured that I misunderstand "milestone" and that you're not going to wait until official support, but will apply my patches to your utf8 patch in the foreseeable future. These patches are so small and trivial that I can see no reason why they couldn't be applied to the very next version of your utf8 patches (4.6.2.1 or 4.6.3).

comment:6 Changed 10 years ago by Patrick Winnertz

Hey Egmont,

Please rest me assured that I misunderstand "milestone" and that you're
not going to wait until official support, but will apply my patches to
your utf8 patch in the foreseeable future.

You can be sure that I'll apply your patches in the next future to the utf8
branch. I've switched the branch to get a better look on the release critical
bugs for the next release.. nothing more. If a bug is moved to a later release
this doesn't meant that it can't be included in a earlier one.. it's simply
about not blocking the milestone.
As we doesn't support utf8 currently officially this really shouldn't be a
blocker for the 4.6.2.1 or 4.6.3 release but you can be sure that this (and
the other bugs you've filled about utf8) will be fixed until the next release
happens.. it's only a change to have a better overview about missing things
for the next release.

I hope this helps you :) and much thanks for your work :) please continue ;-)

Greetings
Winnie

comment:7 Changed 10 years ago by egmont

Thanks very much Winnie :-)

comment:8 Changed 10 years ago by winnie

  • Status changed from accepted to testing
  • Resolution set to fixed

Patch added into both HACK_utf8 branches

comment:9 Changed 10 years ago by winnie

  • Status changed from testing to closed

comment:10 Changed 10 years ago by angel_il

  • Milestone changed from UTF8 Support to 4.7

comment:11 Changed 10 years ago by angel_il

  • Status changed from closed to reopened
  • Resolution fixed deleted

need check it

comment:12 Changed 10 years ago by angel_il

  • Milestone 4.7 deleted

comment:13 Changed 10 years ago by winnie

  • Keywords vote-angel_il vote-kdave removed
  • Votes for changeset set to angel_il kdave
  • severity set to on review

comment:14 Changed 9 years ago by styx

  • Milestone set to future releases

comment:15 Changed 9 years ago by angel_il

  • Status changed from reopened to closed
  • Resolution set to fixed

comment:16 Changed 9 years ago by angel_il

  • Milestone changed from future releases to 4.7
Note: See TracTickets for help on using tickets.