Ticket #242 (closed enhancement: fixed)

Opened 10 years ago

Last modified 10 years ago

remove unnecessary memmove (HAVE_MEMMOVE)

Reported by: metux Owned by: metux
Priority: major Milestone: 4.7
Component: mc-core Version: 4.6.2
Keywords: committed-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

IMHO, every sane libc has memmove today, so our own implementation (in edit/editcmd.c) can be dropped.

(it had been introduced over 12 years ago)

branch:242_remove_memmove
changeset:463a18623d550c62035ae82895fbe41bebb7bf31

Change History

comment:1 Changed 10 years ago by metux

  • Status changed from new to accepted
  • Description modified (diff)

comment:2 Changed 10 years ago by metux

  • Keywords review added
  • Description modified (diff)

comment:3 Changed 10 years ago by winnie

  • Keywords vote-winnie added

comment:4 Changed 10 years ago by slyfox

  • Keywords vote-slyfox approved added; review removed

man memmove:

CONFORMING TO

SVr4, 4.3BSD, C89, C99, POSIX.1-2001.

So, vote! :]

comment:5 Changed 10 years ago by metux

  • Status changed from accepted to testing
  • Keywords committed-master added; vote-winnie vote-slyfox approved removed
  • Resolution set to fixed

comment:6 Changed 10 years ago by winnie

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.