Ticket #226 (closed defect: duplicate)

Opened 11 years ago

Last modified 10 years ago

Fix includes

Reported by: metux Owned by: metux
Priority: major Milestone:
Component: mc-core Version: 4.6.1
Keywords: rework Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

several .c file are missing some #include's, which are currently defined in global.h - very unclean ;-o

branch:226_fix_includes
changeset:851028508bcc2eb82b568351a16e2a553b43eb4e

Change History

comment:1 Changed 11 years ago by metux

  • Keywords review added
  • Status changed from new to accepted
  • Description modified (diff)
  • Owner set to metux

comment:2 Changed 11 years ago by winnie

Well I think we should check that we don't break other systems. Some #ifdef ... #else /*BSD*/ #endif statements are deleted without an replacement. Has anybody access to a BSD System?

comment:3 Changed 11 years ago by slyfox

Some thrown out code snippets look very ancient:
-#ifndef HAVE_MEMMOVE
-/* for Christophe */
-static void *memmove (void *dest, const void *src, size_t n)
-{
...
-}
-#endif /* !HAVE_MEMMOVE */

-/* Replacement for O_NONBLOCK */
-#ifndef O_NONBLOCK
-#ifdef O_NDELAY /* SYSV */
-#define O_NONBLOCK O_NDELAY
-#else /* BSD */
-#define O_NONBLOCK FNDELAY
-#endif /* !O_NDELAY */
-#endif /* !O_NONBLOCK */

-#if !defined(HAVE_SYS_TIME_H)
-struct timeval {

  • long int tv_sec; /* seconds */
  • long int tv_usec; /* microseconds */

-};
-#endif /* !HAVE_SYS_TIME_H */
etc.
Maybe we should have one global implicit config.h to hold that oddities/standard misfollowing?

BTW, what minimal C standard/OS standard compliance do we plan to support?

comment:4 Changed 11 years ago by metux

  • Description modified (diff)

comment:5 Changed 11 years ago by winnie

  • Keywords rework added; review removed

Okay.. there are some things which should be discussed beforehand. Therefore removing review and adding rework.

comment:6 Changed 10 years ago by slyfox

Bug is related to #260

comment:7 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to duplicate
  • Milestone 4.7 deleted

comment:8 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.