Ticket #207 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

Minor regex fixes

Reported by: Patrick Winnertz <winnie@…> Owned by: winnie
Priority: major Milestone: 4.6.2
Component: mc-core Version: 4.6.1
Keywords: vote-slavazanko vote-slyfox approved commited-master commited-mc-4.6 Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by winnie) (diff)

Hey,

There are smaller errors in the regex code of mc, the patches attached here
will fix this issues.
Please review and vote! :)

Attachments

99a_fix-regex-bol-match.patch (492 bytes) - added by Patrick Winnertz 10 years ago.
Added by email2trac
99c_fix-regex-newline-match.patch (439 bytes) - added by Patrick Winnertz 10 years ago.
Added by email2trac

Change History

Changed 10 years ago by Patrick Winnertz

Added by email2trac

comment:1 Changed 10 years ago by Patrick Winnertz

  • id set to 207

This message has 2 attachment(s)

comment:2 Changed 10 years ago by Patrick Winnertz

  • Owner set to winnie
  • Status changed from new to accepted
  • Milestone changed from 4.7 to 4.6.2

This should also be fixed in 4.6.2. Therefore I created a branch called:
207_minor_regex_fixes.

Please review and vote!
Greetings

comment:3 Changed 10 years ago by winnie

  • Keywords review added
  • Description modified (diff)

comment:4 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko added

comment:5 Changed 10 years ago by slyfox

  • Keywords vote-slyfox approved added; review removed

99c_fix-regex-newline-match.patch

Changes regex subst behaviour for following example:
regex: s,3$,TEST,
file_to_edit:

1 2 3
1 2 3
1 2 3

When patch applied all the 3 are substituted, without the patch - only the last occurence. So patch is clearly a Good Thing :]

99a_fix-regex-bol-match.patch

Nothing looks broken, but I could not figure an example to test this change. Could you provide one?

My vote is yours :]

comment:6 Changed 10 years ago by winnie

  • Keywords commited-master commited-mc-4.6 added
  • Status changed from accepted to testing
  • Resolution set to fixed

comment:7 Changed 10 years ago by winnie

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.