Ticket #184 (new defect)

Opened 10 years ago

Last modified 3 years ago

Rename / move (F6) works incorrectly on directories containing "\n"

Reported by: metux Owned by:
Priority: minor Milestone: Future Releases
Component: mc-core Version: 4.8.15
Keywords: Cc:
Blocked By: Blocking: #2325
Branch state: no branch Votes for changeset:

Description (last modified by zaytsev) (diff)

If a directory contains a linefeed character, it is replaced with a space when the directory is moved. Need to check whether this also applies to other "weird" characters.

Old description:

http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc-newlinedir.patch?view=markup

mc crashes after failing to change into a directory whose name contains '\n'. This patch hides the above defect.

Change History

comment:1 follow-up: ↓ 2 Changed 10 years ago by winnie

  • Milestone changed from 4.7 to 4.6.3

Can please someone state what this patch should fix. The description is not that good ;-)

Maybe we should contact the mc maintainer in mandriva

comment:2 in reply to: ↑ 1 Changed 10 years ago by guanx

  • Keywords rework added; review removed

Replying to winnie:

Can please someone state what this patch should fix. The description is not that good ;-)

Maybe we should contact the mc maintainer in mandriva

mc crashes after failing to change into a directory whose name contains '\n'. This patch hides the above defect.

I think it's better to fix this bug than to hide it.

comment:3 Changed 10 years ago by angel_il

  • Description modified (diff)

comment:4 Changed 10 years ago by winnie

  • Milestone changed from 4.6.2.1 to 4.6.3

comment:5 Changed 10 years ago by slavazanko

  • Milestone changed from 4.6.3 to 4.7

comment:6 Changed 10 years ago by iNode

  • severity set to no branch

Works properly in current master.

Test:

[F7]test[C-q][Enter]dir[Enter]
ls -l
and try to enter to this dir in mc

So if there is no other cases I'll close it.

comment:7 follow-up: ↓ 8 Changed 10 years ago by angel_il

mc not craches, but incorrect draw panel if catalog named '\n'.

comment:8 in reply to: ↑ 7 Changed 10 years ago by iNode

Replying to angel_il:

mc not craches, but incorrect draw panel if catalog named '\n'.

It draw '\n' the same way as any other non-printable chars.

I think it's correct. Should we change this behaviour?

comment:9 Changed 10 years ago by iNode

But F6 on that diretory work incorrect. (produce "test dir")

comment:10 Changed 10 years ago by angel_il

transform "test\ndir" to "test dir" - feature

comment:11 Changed 9 years ago by andrew_b

  • Keywords rework mandriva removed

comment:12 Changed 9 years ago by andrew_b

  • Blocking 2325 added

comment:13 Changed 8 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

comment:14 Changed 3 years ago by zaytsev

  • Priority changed from major to minor
  • Version changed from 4.6.1 to 4.8.15
  • Description modified (diff)
  • Summary changed from (mandriva) check if contain a "\n" to Rename / move (F6) works incorrectly on directories containing "\n"
Note: See TracTickets for help on using tickets.