Ticket #1483 (accepted enhancement)
Panel scrollbar
| Reported by: | dborca | Owned by: | slavazanko |
|---|---|---|---|
| Priority: | major | Milestone: | Future Releases |
| Component: | mc-core | Version: | 4.7.0-pre1 |
| Keywords: | Cc: | dborca@…, gotar@…, ales.janda@… | |
| Blocked By: | Blocking: | ||
| Branch state: | no branch | Votes for changeset: |
Description
The following patch adds a primitive scroll indicator to the file panels. It will display only on the active panel, and only if necessary.
Attached patch (against 4.7.0-pre1) does this.
Attachments
Change History
comment:2 follow-up: ↓ 4 Changed 15 years ago by andrew_b
The scrollbar should be implemented as widget to use it where it need.
comment:4 in reply to: ↑ 2 ; follow-up: ↓ 5 Changed 15 years ago by dborca
Replying to andrew_b:
The scrollbar should be implemented as widget to use it where it need.
And where would be that, besides panels? WListboxes already have their own scrollbar.
o·ver·do
- o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does
v.tr.
1.
- To do, use, or stress to excess; carry (something) too far.
- To exaggerate.
- To wear out the strength of; overtax.
- To cook (food) too long.
v.intr.
To do too much; go to extremes.
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 15 years ago by andrew_b
Replying to dborca:
Replying to andrew_b:
The scrollbar should be implemented as widget to use it where it need.
And where would be that, besides panels?
Do you need it right now?
WListboxes already have their own scrollbar.
Yes. This scrollbar should be reinplemented to WScrollbar widget to use it in panels, listboxes, etc.
o·ver·do
- o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does
v.tr.
1.
- To do, use, or stress to excess; carry (something) too far.
- To exaggerate.
- To wear out the strength of; overtax.
- To cook (food) too long.
v.intr.
To do too much; go to extremes.
What is it?
comment:6 in reply to: ↑ 5 Changed 15 years ago by dborca
Replying to andrew_b:
Replying to dborca:
Replying to andrew_b:
The scrollbar should be implemented as widget to use it where it need.
And where would be that, besides panels?
Do you need it right now?
Yes. No. I need it since 1.5 years ago. :) I also have it since 1.5 years ago.
There are various patches for this since the beginning of time. Just look at Debian.
WListboxes already have their own scrollbar.
Yes. This scrollbar should be reinplemented to WScrollbar widget to use it in panels, listboxes, etc.
This is called overdoing things (hunting mosquitoes with a Howitzer). I'd rather save those few extra cycles of CPU for anything better (or memory; or disk space). I'd rather have it the simple way than not having it at all. Ok, so I have it already, sorry for sharing it.
A simple thing that makes life easier, but won't, because it is not implemented The Right Way (tm). But The Right Way (tm) takes too much time, so it won't get implemented in the near future.
o·ver·do
- o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does
v.tr.
1.
- To do, use, or stress to excess; carry (something) too far.
- To exaggerate.
- To wear out the strength of; overtax.
- To cook (food) too long.
v.intr.
To do too much; go to extremes.
What is it?
Sorry, too much coffee :)
comment:7 Changed 15 years ago by slavazanko
- Owner set to slavazanko
- Status changed from new to accepted
crutch
backstay
comment:9 Changed 15 years ago by slavazanko
- severity changed from no branch to on review
- Milestone changed from 4.7.0-pre4 to 4.7.0-pre3
created branch 1483_panel_scrollbar (parent: master)
initial changeset:f8c908bbe94e712f30246fa8611b454261870082
Control drawing of scrollbar via skin-file: changeset:4761bcb42fcb1a067344e50d47bc8974a31af784
TODO: drawing scrollbar in any position of widget, but now I don't see sence to complete this work.
review, please.
comment:10 Changed 15 years ago by slavazanko
- severity changed from on review to on rework
Okay, as we discuss in jabber room, need to rework scrollbar. This must be fully-functional widget (with reaction on mouse scroll or click) and need to add srollbar (as widget) into LIST, PANEL etc. elements (not in all widgets).
comment:12 Changed 15 years ago by slavazanko
- severity changed from on rework to on review
Branch rebased.
New commits history:
- 5e801d1891e8e7c1b57523e56902bfb4c9467d19: Move all widgets-related files into subdir
- e00d9dc4dd45b2e39103aae54bfe4be324f56c04: move move widget_t declaration into widget-struct.h file
- 8dcc09c9f8f84f58f12a72e555566cdfe462689f: Change type of widget callbals.
- a59f5df23356455561ca22547079d2d375443f95: fix commit: Checked dialogs return value in all files.
- ca5989ab691a6f7aae26c972cd3cab173b7354a3: Split one big widget.c into set of files
- 31084e65b68e5d3ef2d37780dc0cf923b0b6e1bd: Added scrollbar widget. Also, added scrollbar into panel and listbox widgets.
Review, please.
comment:13 Changed 15 years ago by slavazanko
- ac6fdc4d5d42c5df3e026779be7cca39636d6e2f: Fix segfault if no entryes for scrolling
comment:14 Changed 15 years ago by slavazanko
- 10bc96adb96651f84593b67c759fcaa97db9d127: Added option 'show scrollbar' into 'Layout' config
comment:18 Changed 13 years ago by andrew_b
- Branch state set to no branch
- Milestone changed from 4.7 to Future Releases
