Ticket #1483 (accepted enhancement)

Opened 10 years ago

Last modified 6 years ago

Panel scrollbar

Reported by: dborca Owned by: slavazanko
Priority: major Milestone: Future Releases
Component: mc-core Version: 4.7.0-pre1
Keywords: Cc: dborca@…, gotar@…
Blocked By: Blocking: #3146
Branch state: no branch Votes for changeset:

Description

The following patch adds a primitive scroll indicator to the file panels. It will display only on the active panel, and only if necessary.

Attached patch (against 4.7.0-pre1) does this.

Attachments

mc-4.7.0-pre1.scrollbar.patch.gz (654 bytes) - added by dborca 10 years ago.
mc-4.7.0-pre1.scrollbar.patch (1.3 KB) - added by angel_il 10 years ago.

Change History

Changed 10 years ago by dborca

comment:1 Changed 10 years ago by dborca

  • Cc dborca@… added

comment:2 follow-up: ↓ 4 Changed 10 years ago by andrew_b

The scrollbar should be implemented as widget to use it where it need.

Changed 10 years ago by angel_il

comment:3 Changed 10 years ago by slavazanko

  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

comment:4 in reply to: ↑ 2 ; follow-up: ↓ 5 Changed 10 years ago by dborca

Replying to andrew_b:

The scrollbar should be implemented as widget to use it where it need.

And where would be that, besides panels? WListboxes already have their own scrollbar.

o·ver·do

  1. o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does

v.tr.
1.

  1. To do, use, or stress to excess; carry (something) too far.
  2. To exaggerate.
  3. To wear out the strength of; overtax.
  4. To cook (food) too long.

v.intr.
To do too much; go to extremes.

comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 10 years ago by andrew_b

Replying to dborca:

Replying to andrew_b:

The scrollbar should be implemented as widget to use it where it need.

And where would be that, besides panels?

Do you need it right now?

WListboxes already have their own scrollbar.

Yes. This scrollbar should be reinplemented to WScrollbar widget to use it in panels, listboxes, etc.

o·ver·do

  1. o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does

v.tr.
1.

  1. To do, use, or stress to excess; carry (something) too far.
  2. To exaggerate.
  3. To wear out the strength of; overtax.
  4. To cook (food) too long.

v.intr.
To do too much; go to extremes.

What is it?

comment:6 in reply to: ↑ 5 Changed 10 years ago by dborca

Replying to andrew_b:

Replying to dborca:

Replying to andrew_b:

The scrollbar should be implemented as widget to use it where it need.

And where would be that, besides panels?

Do you need it right now?

Yes. No. I need it since 1.5 years ago. :) I also have it since 1.5 years ago.
There are various patches for this since the beginning of time. Just look at Debian.

WListboxes already have their own scrollbar.

Yes. This scrollbar should be reinplemented to WScrollbar widget to use it in panels, listboxes, etc.

This is called overdoing things (hunting mosquitoes with a Howitzer). I'd rather save those few extra cycles of CPU for anything better (or memory; or disk space). I'd rather have it the simple way than not having it at all. Ok, so I have it already, sorry for sharing it.

A simple thing that makes life easier, but won't, because it is not implemented The Right Way (tm). But The Right Way (tm) takes too much time, so it won't get implemented in the near future.

o·ver·do

  1. o·ver·did, o·ver·done, o·ver·do·ing, o·ver·does

v.tr.
1.

  1. To do, use, or stress to excess; carry (something) too far.
  2. To exaggerate.
  3. To wear out the strength of; overtax.
  4. To cook (food) too long.

v.intr.
To do too much; go to extremes.

What is it?

Sorry, too much coffee :)

comment:7 Changed 10 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

crutch
backstay

comment:8 Changed 10 years ago by angel_il

  • Milestone changed from 4.7.0-pre3 to 4.7.0-pre4

comment:9 Changed 10 years ago by slavazanko

  • severity changed from no branch to on review
  • Milestone changed from 4.7.0-pre4 to 4.7.0-pre3

created branch 1483_panel_scrollbar (parent: master)

initial changeset:f8c908bbe94e712f30246fa8611b454261870082

Control drawing of scrollbar via skin-file: changeset:4761bcb42fcb1a067344e50d47bc8974a31af784

TODO: drawing scrollbar in any position of widget, but now I don't see sence to complete this work.

review, please.

comment:10 Changed 10 years ago by slavazanko

  • severity changed from on review to on rework

Okay, as we discuss in jabber room, need to rework scrollbar. This must be fully-functional widget (with reaction on mouse scroll or click) and need to add srollbar (as widget) into LIST, PANEL etc. elements (not in all widgets).

comment:11 Changed 10 years ago by angel_il

  • Milestone changed from 4.7.0-pre3 to 4.7.0-pre4

comment:12 Changed 10 years ago by slavazanko

  • severity changed from on rework to on review

Branch rebased.
New commits history:

Review, please.

comment:13 Changed 10 years ago by slavazanko

comment:14 Changed 10 years ago by slavazanko

comment:15 Changed 10 years ago by slavazanko

  • severity changed from on review to on rework

comment:16 Changed 10 years ago by slavazanko

  • Milestone changed from 4.7.0-pre4 to 4.7

comment:17 Changed 10 years ago by gotar

  • Cc gotar@… added

comment:18 Changed 8 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

comment:19 Changed 6 years ago by andrew_b

  • Blocking 3146 added
Note: See TracTickets for help on using tickets.