Ticket #1459 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

link fail with --enable-vfs-undelfs and --enable-vfs configure options

Reported by: ssuominen Owned by: iNode
Priority: major Milestone: 4.7.0-pre2
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

mc-4.7.0_pre1 with --enable-vfs-undelfs and --enable-vfs fails at linking phase

Reproducing:

./configure --enable-vfs-undelfs --enable-vfs
make

Expected result:

undelfs feature like on 4.6.1 or 4.6.2_pre has

Result:

libtool: link: gcc -std=gnu99 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I.. -g -O2 -Wall -o mc achown.o background.o boxes.o chmod.o chown.o cmd.o color.o command.o complete.o cons.handler.o dialog.o dir.o execute.o ext.o file.o filegui.o filenot.o fileopctx.o find.o findme.o glibcompat.o help.o hotlist.o info.o key.o keyxdef.o layout.o learn.o listmode.o logging.o main.o menu.o mountlist.o mouse.o option.o panelize.o popt.o poptconfig.o popthelp.o poptparse.o rxvt.o screen.o setup.o slint.o subshell.o textconf.o tree.o treestore.o tty.o user.o util.o utilunix.o view.o widget.o win.o wtools.o x11conn.o ecs.o strutil.o strutilascii.o strutil8bit.o strutilutf8.o strescape.o -Wl,--export-dynamic -I/usr/include ../edit/libedit.a ../vfs/libvfs-mc.a /usr/lib64/libgmodule-2.0.so -L/usr/lib64 -ldl /usr/lib64/libglib-2.0.so -lext2fs -lcom_err -lgpm -L/usr/lib -lslang search/.libs/libsearch.a mcconfig/.libs/libmcconfig.a
../vfs/libvfs-mc.a(vfs.o): In function `vfs_init':
/home/ssuominen/tmp/mc-4.7.0-pre1/vfs/vfs.c:1236: undefined reference to `init_undelfs'
collect2: ld returned 1 exit status

System:

Gentoo Linux, GCC 4.4.1, GLIBC 2.10.1, built without Portage (by hand) without any environment flags defined but the result is same with Portage with all the environment flags set also.

Let me know if you need more information...

Change History

comment:1 Changed 9 years ago by iNode

Are you sure you has e2fslibs-dev or it analog installed? Configure stage pass ok?
Did you try build mc from with ebuild? It's finish with same error?

comment:2 Changed 9 years ago by iNode

Ok, I can reproduce your problem. Thanks for report.

comment:3 Changed 9 years ago by iNode

It's seems like libext2fs internals cnahged.

comment:4 Changed 9 years ago by iNode

  • Owner set to iNode
  • Status changed from new to accepted

comment:5 Changed 9 years ago by iNode

Finally. This is just build issue, for now before we fix it, just execute:

 cd vfs
 gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I/usr/include/glib-2.0 \
  -I/usr/lib/glib-2.0/include -I.. -g -O2 -Wall -MT fish.o -MD -MP \
  -MF .deps/undelfs.Tpo -c -o undelfs.o undelfs.c
 ar cru libvfs-mc.a tcputil.o fish.o ftpfs.o mcfs.o mcfsutil.o \
  cpio.o direntry.o extfs.o gc.o local.o tar.o sfs.o utilvfs.o vfs.o undelfs.o
 cd ..
 make

and check that is work correct.

comment:6 Changed 9 years ago by iNode

  • Version changed from 4.7.0-pre1 to master
  • severity changed from no branch to on review

branch:1459_undelfs_autoconf (parent:master)
5894396494f0f00d385e39f31c4a8144515613af

comment:7 Changed 9 years ago by iNode

  • Summary changed from mc-4.7.0_pre1 with --enable-vfs-undelfs and --enable-vfs fails at linking phase to link fail with --enable-vfs-undelfs and --enable-vfs configure options

comment:8 Changed 9 years ago by slyfox

  • Votes for changeset set to slyfox

Good.

comment:9 Changed 9 years ago by styx

  • Votes for changeset changed from slyfox to slyfox styx
  • severity changed from on review to approved

comment:10 Changed 9 years ago by iNode

  • Status changed from accepted to testing
  • Votes for changeset changed from slyfox styx to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:11 Changed 9 years ago by iNode

  • Status changed from testing to closed

comment:12 Changed 9 years ago by ssuominen

Thanks.

Applied it to Gentoo version of mc-4.7.0_pre1 as well.

Note: See TracTickets for help on using tickets.