Ticket #1375 (closed enhancement: fixed)

Opened 10 years ago

Last modified 10 years ago

New design of 'Find File' dialog

Reported by: andrew_b Owned by: andrew_b
Priority: minor Milestone: 4.7.0-pre1
Component: mc-core Version: master
Keywords: commited-master Cc:
Blocked By: Blocking: #1385
Branch state: Votes for changeset:

Description

The new design of 'Find File' dialog is proposed.

Change History

comment:1 Changed 10 years ago by andrew_b

  • Status changed from new to accepted
  • Keywords review added
  • Owner set to andrew_b

1375_findfile_dialog branch is created. Parent branch: master.
Initial changeset:0197df062c7dcb957e2817bda04d4385aed206b8

comment:2 follow-up: ↓ 3 Changed 10 years ago by angel_il

look good...
maybe replace

if (var !=NULL)

to

if (a) 

and

if (var == NULL) 

to

if (!a)
if (var) 
    g_free (var); 

to

    g_free (var); 

comment:3 in reply to: ↑ 2 Changed 10 years ago by andrew_b

Replying to angel_il:

look good...
maybe replace

if (var !=NULL)

to

if (a) 

and

if (var == NULL) 

to

if (!a)

No. I dislike that. 'a' is a pointer not a boolean. If I see if (a) I expect that 'a' is variable of boolean not something else.
I prefer strong typization as match as C allows that.

if (var) 
    g_free (var); 

to

    g_free (var); 

Yes. g_free() is safety so there is not need the extra check.

comment:4 Changed 10 years ago by angel_il

  • Keywords vote-angel_il added

comment:5 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko approved added; review removed

comment:6 follow-up: ↓ 7 Changed 10 years ago by andrew_b

  • Keywords commited-master added; vote-angel_il vote-slavazanko approved removed
  • Status changed from accepted to testing
  • Resolution set to fixed

Merged to master.
cnahgeset:d5f1442438a67ad8b4c890c90ba4fabfa047d901

comment:7 in reply to: ↑ 6 Changed 10 years ago by andrew_b

  • Status changed from testing to closed

comment:8 Changed 10 years ago by slyfox

  • Blocking 1385 added

(In #1385) #1375 looks like bug fixer

Note: See TracTickets for help on using tickets.