Ticket #133 (accepted defect) — at Version 10

Opened 16 years ago

Last modified 16 years ago

[PATCH] fix use of obsolete autoconf macros

Reported by: metux Owned by: metux
Priority: minor Milestone: 4.6.2
Component: mc-core Version: 4.6.1
Keywords: vote-winnie vote-metux commited-master commited-mc-4.6 Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

This patch fixes the use of obsolete autoconf macros: AC_AIX, AC_MINIX

Applied to mc-4.6: changeset:40d105b11b7a88314a981009171ef74f381a5b1d
Applied to master: changeset:c63fc340b9200637c3e45c377a85e070a83a47b9

Change History

Changed 16 years ago by metux

comment:1 Changed 16 years ago by slavazanko

This patch for 4.6.1

For 'master' branch patch is a different.

Changed 16 years ago by slavazanko

patch for 'master' branch

comment:2 Changed 16 years ago by metux

  • Keywords review added

comment:3 Changed 16 years ago by slavazanko

Relative to: ​autoconf-patches at gnu.org we must don't use AC_GNU_SOURCE, AC_AIX, AC_MINIX.

created branch '133_obsolete_autoconf_macros' from branch 'mc-4.6'

comment:4 Changed 16 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

comment:5 Changed 16 years ago by slavazanko

In /usr/share/autoconf/autoconf/specific.m4 (on my Fedora-10) next definitions:

...
AU_DEFUN([AC_GNU_SOURCE], [AC_USE_SYSTEM_EXTENSIONS])
...
AU_DEFUN([AC_AIX], [AC_USE_SYSTEM_EXTENSIONS])
...
AU_DEFUN([AC_MINIX], [AC_USE_SYSTEM_EXTENSIONS])
...

As fact, these macros is an aliases for AC_USE_SYSTEM_EXTENSIONS

comment:6 Changed 16 years ago by slavazanko

  • Keywords review, vote-slavazanko added; review removed

comment:7 Changed 16 years ago by metux

  • Owner changed from slavazanko to metux

comment:8 Changed 16 years ago by winnie

  • Keywords review vote-winnie approved added; review, removed

Hey,
Please go on and merge this fix into mc-4.6 and then merge mc-4.6 into master.

Btw. keywords are _space_ separated.. then you'll see only a "added keywords: xyz" instead of a "added: abc, xyz removed: abc"...

Greetings
Winnie

comment:9 Changed 16 years ago by winnie

  • Keywords review removed

Remove review keyword.. no more review is needed.

comment:10 Changed 16 years ago by metux

  • Keywords committed-mc4.6 committed-master added; approved removed
  • Description modified (diff)
Note: See TracTickets for help on using tickets.