Ticket #133 (closed defect: fixed)
[PATCH] fix use of obsolete autoconf macros
| Reported by: | metux | Owned by: | slavazanko |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.6.2 |
| Component: | mc-core | Version: | 4.6.1 |
| Keywords: | vote-winnie vote-metux commited-master commited-mc-4.6 | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description (last modified by metux) (diff)
This patch fixes the use of obsolete autoconf macros: AC_AIX, AC_MINIX
Applied to mc-4.6: changeset:40d105b11b7a88314a981009171ef74f381a5b1d
Applied to master: changeset:c63fc340b9200637c3e45c377a85e070a83a47b9
Attachments
Change History
comment:1 Changed 16 years ago by slavazanko
This patch for 4.6.1
For 'master' branch patch is a different.
Changed 16 years ago by slavazanko
- Attachment mc-4.6.1-ac-fix-obsolete-ac_aix-rev2.diff added
patch for 'master' branch
comment:3 Changed 16 years ago by slavazanko
Relative to: autoconf-patches at gnu.org we must don't use AC_GNU_SOURCE, AC_AIX, AC_MINIX.
created branch '133_obsolete_autoconf_macros' from branch 'mc-4.6'
comment:4 Changed 16 years ago by slavazanko
- Owner set to slavazanko
- Status changed from new to accepted
comment:5 Changed 16 years ago by slavazanko
In /usr/share/autoconf/autoconf/specific.m4 (on my Fedora-10) next definitions:
... AU_DEFUN([AC_GNU_SOURCE], [AC_USE_SYSTEM_EXTENSIONS]) ... AU_DEFUN([AC_AIX], [AC_USE_SYSTEM_EXTENSIONS]) ... AU_DEFUN([AC_MINIX], [AC_USE_SYSTEM_EXTENSIONS]) ...
As fact, these macros is an aliases for AC_USE_SYSTEM_EXTENSIONS
comment:8 Changed 16 years ago by winnie
- Keywords review vote-winnie approved added; review, removed
Hey,
Please go on and merge this fix into mc-4.6 and then merge mc-4.6 into master.
Btw. keywords are _space_ separated.. then you'll see only a "added keywords: xyz" instead of a "added: abc, xyz removed: abc"...
Greetings
Winnie
comment:9 Changed 16 years ago by winnie
- Keywords review removed
Remove review keyword.. no more review is needed.
comment:10 Changed 16 years ago by metux
- Keywords committed-mc4.6 committed-master added; approved removed
- Description modified (diff)
comment:12 Changed 16 years ago by winnie
@metux: Can you set please resolution to fixed if it is really commited to mc-4.6 and master? As I'm online currently from a win pc (from a friend) I can't check this.
comment:13 Changed 16 years ago by winnie
- Status changed from accepted to testing
- Resolution set to fixed
comment:15 Changed 16 years ago by andrew_b
- Status changed from closed to reopened
- Resolution fixed deleted
AC_USE_SYSTEM_EXTENSIONS macro requires autoconf >= 2.60 (http://www.gnu.org/software/hello/manual/autoconf/Posix-Variants.html).
So AC_PRERQ(2.54) in configure.ac need to be fixed.
comment:16 Changed 16 years ago by slavazanko
- Owner changed from metux to slavazanko
- Keywords review added; vote-slavazanko vote-winnie committed-mc-4.6 committed-master removed
- Status changed from reopened to accepted
Created branch 133_ac_prereq with fix; parent branch: mc-4.6
Review, rework if need, vote please.
comment:19 Changed 16 years ago by slavazanko
- Keywords commited-master commited-mc-4.6 added; approved removed
- Status changed from accepted to testing
- Resolution set to fixed
Merge to master: changeset:d5565fb6784407bdd0e5b02511440bb0eaad3b93
Merge to mc-4.6: changeset:6a26036bacccbbb0a68491152e10ea1f786f359b
