Ticket #89 (closed defect: fixed)
savannah: mc shows wrong metadata for ".." directory
Reported by: | darkk | Owned by: | andrew_b |
---|---|---|---|
Priority: | major | Milestone: | 4.7 |
Component: | mc-core | Version: | 4.6.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Branch state: | merged | Votes for changeset: | commited-master |
Description (last modified by ossi) (diff)
Original: http://savannah.gnu.org/bugs/?24808
Submitted by: | Leonid Evdokimov <darkk> | Submitted on: | Tue 11 Nov 2008 08:22:32 AM UTC |
Category: | Screen output | Severity: | 3 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Release: | 4.6.1 | Operating System: | GNU/Linux |
Original submission:
mc always shows 0755 as ".." permissions — that's incorrect behaviour. Much better way is to show nothing as mc does not show mtime, size and some other attributes of ".." at all. User, group and some other values are broken too, seems, src/screen.c should be patched to check for ".." in more places.
Change History
comment:1 Changed 16 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Version set to 4.6.2
- Keywords review added
- Milestone set to 4.7
comment:2 follow-up: ↓ 3 Changed 16 years ago by slavazanko
- Keywords vote-slavazanko added
IMHO good solution. Patch contain comment:
FIXME: while loading directory (do_load_dir() and do_reload_dir(), the actual stat info about ".." directory isn't got; so just don't display incorrect info about ".." directory
I think, not needed to retrieve stat info for '..' directory. What think others?
comment:3 in reply to: ↑ 2 Changed 16 years ago by styx
- Keywords vote-styx approved added; review removed
Replying to slavazanko:
IMHO good solution. Patch contain comment:
FIXME: while loading directory (do_load_dir() and do_reload_dir(), the actual stat info about ".." directory isn't got; so just don't display incorrect info about ".." directoryI think, not needed to retrieve stat info for '..' directory. What think others?
I am agree with you, there is no need to get stat info for '..' directory.
comment:4 Changed 16 years ago by andrew_b
- Status changed from accepted to testing
- Keywords commited-master added; vote-slavazanko vote-styx approved removed
- Resolution set to fixed
Note: See
TracTickets for help on using
tickets.
89_parent_dir_metadata is created; parent branch: master.
Solution: display "UP--DIR" in mini-status when ".." is selected.