Ticket #4629 (closed defect: fixed)

Opened 6 weeks ago

Last modified 6 weeks ago

Changing file attributes inside extfs (e.g. zip archive) silently fails

Reported by: ilyagr Owned by: andrew_b
Priority: major Milestone: 4.8.33
Component: mc-vfs Version: 4.8.32
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

  1. Open a ZIP archive by pressing Enter on it in the left pane. In my case, the file had VSIX extension (don't think it matters)
  2. Pick some file, e.g. a file that's not executable because of https://midnight-commander.org/ticket/4628 but should be
  3. Try making it executable with either File -> Chown or File -> Advanced chown

I was hoping this would succeed (this could be considered an FR), but if it's not implemented, I expected to see an error message. Instead, nothing happens.

This is related to https://midnight-commander.org/ticket/4628 . See there for some more debug info.

Change History

comment:1 Changed 6 weeks ago by ilyagr

  • Version changed from master to 4.8.32

comment:2 follow-up: ↓ 3 Changed 6 weeks ago by andrew_b

  • Component changed from mc-core to mc-vfs

Apparently, the duplicate of #4558.

comment:3 in reply to: ↑ 2 Changed 6 weeks ago by andrew_b

Replying to andrew_b:

Apparently, the duplicate of #4558.

Sorry, #4628 is the duplicate of #4558.

Last edited 6 weeks ago by andrew_b (previous) (diff)

comment:4 Changed 6 weeks ago by zaytsev

  • Summary changed from Trying to change attributes of a file inside a zip archive silently fails to Changing file attributes inside extfs (e.g. zip archive) silently fails

comment:5 Changed 6 weeks ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.33

Branch: 4629_extfs_chmod
changeset:ba19a55580a76bbecdd7cac425e4d36532e77965

comment:6 Changed 6 weeks ago by zaytsev

  • Votes for changeset set to zaytsev
  • Branch state changed from on review to approved

I think this is an improvement of the status quo... hopefully this won't spur the demand for implementing chown/chmod for extfs ;)

comment:7 Changed 6 weeks ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from zaytsev to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [25038829b184f0fba29f3d5313305247201ba29c].

comment:8 Changed 6 weeks ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.