Ticket #4615 (accepted enhancement)

Opened 25 hours ago

Last modified 7 hours ago

ext.d: Select browser at runtime

Reported by: and Owned by: zaytsev
Priority: trivial Milestone: 4.8.33
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: approved Votes for changeset: andrew_b

Description

Current browser selection happen on compile time and should change to runtime selection.

  • add chromium browser to list
  • bonus: remove shellcheck warning

Attachments

mc-4615-select-browser-at-runtime.patch​ (1.7 KB) - added by and 25 hours ago.

Change History

Changed 25 hours ago by and

comment:1 Changed 18 hours ago by zaytsev

  • Owner set to zaytsev
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.33

Sounds like a good idea, actually.

TODO: maybe move chromium up the list and add chrome? Not sure what are the most popular browsers on Linux these days.

comment:2 Changed 11 hours ago by zaytsev

  • Branch state changed from no branch to on review

Branch: 4615_browser_runtime
Changeset: f8f220da17eaa6cce93ca820e214e4877e604160

Added brave, chrome and safari (open).

comment:3 Changed 7 hours ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

I've added a fixup: there are no any substitutions in web.sh anymore.

Last edited 7 hours ago by andrew_b (previous) (diff)
Note: See TracTickets for help on using tickets.