Ticket #4100 (accepted enhancement)

Opened 4 months ago

Last modified 3 weeks ago

Add WIM archive(image) support

Reported by: MooSE Owned by: andrew_b
Priority: major Milestone: 4.8.26
Component: mc-vfs Version: master
Keywords: wim, archive Cc:
Blocked By: Blocking:
Branch state: on review Votes for changeset:

Description

Hi!

My small pull request: https://github.com/MidnightCommander/mc/pull/154

It improve "view" feature by adding support for WIM files

Also it improve extfs.d by adding support for WIM files. For now it allow:

  • Add / Extract / Remove files
  • Remove sub images
  • Optimize / Verify archives
  • VIew archive(image) info

sub Images visible like subdirectories (IMAGE1, IMAGE2...)

Optimize and verify works via virtual files (like INSTALL in deb/rpm).

Attachments

mc_wim_support.patch (6.2 KB) - added by MooSE 4 months ago.

Change History

comment:1 follow-up: ↓ 2 Changed 4 months ago by andrew_b

This patch contains some irrelevant info. Please clean it up.

comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed 4 months ago by MooSE

Replying to andrew_b:

This patch contains some irrelevant info. Please clean it up.

[Done]

:)

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 4 months ago by andrew_b

Replying to MooSE:

Replying to andrew_b:

This patch contains some irrelevant info. Please clean it up.

[Done]

:)

Done what?

https://patch-diff.githubusercontent.com/raw/MidnightCommander/mc/pull/154.patch

still contains a lot of already committed code.

comment:4 in reply to: ↑ 3 Changed 4 months ago by MooSE

Replying to andrew_b:

Done what?

https://patch-diff.githubusercontent.com/raw/MidnightCommander/mc/pull/154.patch

still contains a lot of already committed code.

Ohhh....

I close pull request, cleanup code and open new request:

https://github.com/MidnightCommander/mc/pull/155

This code test on Linux and FreeBSD. And must be work on other systemes with sh, awk, wimtools.

comment:5 follow-up: ↓ 6 Changed 4 months ago by ossi

there was no need to create a new PR. you can clean up the history (git rebase -i) and force-push into the existing branch (the PR does automatically reflect that).

Last edited 4 months ago by ossi (previous) (diff)

comment:6 in reply to: ↑ 5 Changed 4 months ago by MooSE

Replying to ossi:

there was no need to create a new PR. you can clean up the history (git rebase -i) and force-push into the existing branch (the PR does automatically reflect that).

I'm trying force push, but PR still closed, and i don't know how i can it reopen. I'm not familiar with github and don't know what i can do for reopen.

comment:7 Changed 4 months ago by andrew_b

It would be great that you attach your patch here.

Changed 4 months ago by MooSE

comment:8 Changed 4 months ago by MooSE

OK. Patch here.

comment:9 Changed 4 months ago by zaytsev

  • Milestone changed from 4.8.25 to 4.8.26

comment:10 Changed 3 weeks ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review

Applied with some changes.

Branch: 4100_wim
changeset:26d57e311ebc46218df125df4fb6d46807c49954

Please test.

Note: See TracTickets for help on using tickets.