Ticket #3430 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

[patch] introduce -Wundef check to catch macro typos

Reported by: and Owned by:
Priority: minor Milestone: 4.8.15
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description

introduce -Wundef check to catch macro typos
more infos about motivation at ​https://sourceware.org/glibc/wiki/Wundef

patch 01/04: use always defined MC_HOMEDIR_XDG macro
patch 02/04: remove superfluous macro check
patch 03/04: use #ifdef for autoconf provided marcos
patch 04/04: use -Wundef compiler option for future compile checks

Attachments

mc-indroduct-wundef-check-01.patch​ (2.7 KB) - added by and 10 years ago.
mc-indroduct-wundef-check-02.patch​ (1.6 KB) - added by and 10 years ago.
mc-indroduct-wundef-check-03.patch​ (2.4 KB) - added by and 10 years ago.
mc-indroduct-wundef-check-04.patch​ (607 bytes) - added by and 10 years ago.
mc-indroduct-wundef-check-02_v2.patch​ (3.1 KB) - added by and 10 years ago.
v2 of patch 02: respect macro logic

Change History

Changed 10 years ago by and

Changed 10 years ago by and

Changed 10 years ago by and

Changed 10 years ago by and

Changed 10 years ago by and

v2 of patch 02: respect macro logic

comment:1 Changed 10 years ago by andrew_b

  • Blocked By 3420 added

comment:2 Changed 10 years ago by andrew_b

  • Blocked By 3420 removed

comment:3 Changed 10 years ago by andrew_b

  • Status changed from new to closed
  • Votes for changeset set to committed-master
  • Resolution set to fixed
  • Milestone changed from Future Releases to 4.8.15

Thanks!
Applied as [8a2f9e253d2a0c808d8a84d838eae066c9da825c], [d0d7d412a78f5cb11002648b2c79ae785d76a6ee], [57452f656b997d66286b65b24fa32f1c5c3eb3ce], [850073cbbbc63ad5ef44b8aaa5030bbfe9ea4bf1].

Note: See TracTickets for help on using tickets.