Ticket #3066 (closed task: fixed)

Opened 4 years ago

Last modified 4 years ago

Refactoring of dir_list and related code

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.8.11
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

typedef struct
{
    file_entry *list;
    int size;
} dir_list;

The dir_list structure contains two members:

  • list -- the array of file_entry items
  • size -- number of allocated items in list (the capacity)

There is no member here which stored number of used elements in list. This info is kept outside dir_list (WPanel::count for reference). Actually, dir_list should have a member (len) to keep an actual length of list (number of used elements).

Change History

comment:1 Changed 4 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.11

comment:2 Changed 4 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:3 Changed 4 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:4 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [cc980f3c50242388bfa3fa60ab7ddd24c3f9369c].

git log --pretty=oneline a339ad3..cc980f3

comment:5 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.