Ticket #269 (closed defect: fixed)
Revert from mhl to Glib
| Reported by: | Patrick Winnertz <winnie@…> | Owned by: | winnie |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7 |
| Component: | mc-core | Version: | 4.6.2 |
| Keywords: | vote-angel_il vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko vote-styx committed-master committed-mc-4.6 | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description (last modified by winnie) (diff)
Hey,
After a huge discussion in our jabber room we decided to not replace glib with
own written code but revert this and use in the future glib.
If there are any systems which will need a very small mc there is eglib.
As this branch was created prior filling this bug the branchname doesn't start
with the id of this ticket but is just called "revert_mhl_to_glib". Please
review this and vote.
Thanks in advance
Greetings
Winnie
Change History
comment:2 Changed 16 years ago by winnie
- Status changed from new to accepted
- Owner set to winnie
- Description modified (diff)
This is only the bug for master branch.. After applying this there we'll backport this to 4.6.
comment:4 Changed 16 years ago by andrew_b
What's wrong with S-Lang?
configure: error: Rejecting S-Lang with UTF-8 support, it's not fully supported yet.
comment:5 follow-up: ↓ 9 Changed 16 years ago by andrew_b
mhl headers are still included in vfs/smbfs.c file.
comment:9 in reply to: ↑ 5 Changed 16 years ago by winnie
Replying to andrew_b:
mhl headers are still included in vfs/smbfs.c file.
Thanks.. this is fixed now.
comment:10 Changed 16 years ago by miguel
- Keywords vote-miguel added
Adding vote-miguel thanks for all the work Patrick!
comment:11 Changed 16 years ago by slavazanko
- Keywords vote-slavazanko added
Well... we need to one-style of writing code. MHL was attempt (don't successfull attempt), and my vote for removal this here.
As for me, not important less size of the code or more speed of code (a few nanoseconds faster).
For me important understanding of source code written in one style.
comment:12 in reply to: ↑ description Changed 16 years ago by angel_il
- Keywords vote-angel_il added; review vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko removed
it's work
comment:13 Changed 16 years ago by angel_il
- Keywords vote-slyfox vote-andrew_b vote-winnie vote-miguel vote-slavazanko added
comment:15 Changed 16 years ago by styx
- Status changed from accepted to testing
- Resolution set to fixed
comment:16 Changed 16 years ago by slavazanko
- Keywords committed-master committed-mc-4.6 added; approved removed
This message has 0 attachment(s)