Ticket #2626 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

Special chars are not escaped in file name autocompletion

Reported by: Hartmut Figge <h figge gmx de> Owned by: andrew_b
Priority: major Milestone: 4.8.8
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Reported in mc-devel@ mailing list: ​http://mail.gnome.org/archives/mc-devel/2011-October/msg00001.html

Downloading a patch from bugzilla/mozilla gives a file with the name
attachment.cgi?id=564208. My build script requires, that a patch begins
with 'patch'. Trying a rename to patch_attachment.cgi?id=564208 with mc
results in patch_attachment.cgiattachment.cgi?id=564208id=564208

Steps to reproduce:
mkdir mc-test
cd mc-test
touch attachment.cgi?id=564208
mc
Point to this file, press F6, type the letter a then ESC then TAB, press
Home, then patch_ and then the button OK.

Special chars like ? should be escaped while autocompletion file names.

Change History

comment:1 Changed 13 years ago by andrew_b

  • Status changed from new to accepted
  • Summary changed from Special chars are not escaped in autocompletion to Special chars are not escaped in file name autocompletion
  • Keywords stable-candidate added
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.0
  • Owner set to andrew_b

Created 2626_escape_autocompletion branch (parent: master).
changeset:d6460a2f9a5e588937a76ba055aaa7a5fc110ee4

comment:2 Changed 13 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:3 Changed 13 years ago by andrew_b

  • Votes for changeset slavazanko deleted
  • Branch state changed from on review to on rework

comment:4 Changed 13 years ago by andrew_b

  • Branch state changed from on rework to on review

New changeset:0e988565caf1424f75b50e215021a0b2ad8c5aa1

Version 1, edited 13 years ago by andrew_b (previous) (next) (diff)

comment:5 Changed 13 years ago by andrew_b

  • Milestone changed from 4.8.0 to 4.8.1

comment:6 Changed 13 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:7 Changed 13 years ago by andrew_b

  • Votes for changeset slavazanko deleted
  • Branch state changed from on review to on rework

comment:8 Changed 13 years ago by andrew_b

  • Keywords stable-candidate removed

comment:9 Changed 13 years ago by andrew_b

  • Milestone changed from 4.8.1 to 4.8

comment:10 Changed 13 years ago by andrew_b

  • Blocked By 55 added
  • Milestone changed from 4.8 to Future Releases

comment:11 Changed 12 years ago by slavazanko

  • Blocked By 55 removed

(In #55) merged to master: 

git log --pretty=oneline 74d71e7..0608af2

comment:12 Changed 12 years ago by andrew_b

  • Branch state changed from on rework to on review
  • Milestone changed from Future Releases to 4.8.8

Rebased to current master.

Branch:2626_escape_autocompletion.
Initial changeset:c24640fdb5453d3b161990fbfc988772f127ac4c

comment:13 Changed 12 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:14 Changed 12 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:15 Changed 12 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [11b5a9a56a9ce6053090095aeb5bba5916860fb6].

git log --pretty=oneline d35b4b1..11b5a9a

comment:16 Changed 12 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.