Ticket #2625 (closed defect: fixed)
[patch ready] mc does not preserve file mtime when copying over ssh
| Reported by: | sergem | Owned by: | slavazanko |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8 |
| Component: | mc-vfs | Version: | 4.7.5.5 |
| Keywords: | Cc: | gotar@… | |
| Blocked By: | Blocking: | #51 | |
| Branch state: | merged | Votes for changeset: | commited-master commited-stable |
Description
mc does not preserve file mtime when copying over ssh
Attached patch should fix this problem.
Attachments
Change History
Changed 13 years ago by sergem
- Attachment mc-4.7.5.5-sshutime-perl.patch added
Same patch, but using perl utime and fallback to touch if no perl found
comment:2 Changed 13 years ago by slavazanko
- Owner set to slavazanko
- Status changed from new to accepted
comment:3 Changed 13 years ago by slavazanko
- Keywords stable-candidate added
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8
Created two branches:
- 2625_fish_mtime (based on master branch, changeset:ce785b401fd3c361c5b03dca238121aabeedd82f)
- 2625_fish_mtime_stable (based on 4.7.5-stable branch, changeset:68652ea50bf597b44e78a59c50e0086185da09a3)
Review, please.
comment:6 Changed 13 years ago by andrew_b
- Votes for changeset changed from angel_il to angel_il amdrew_b
- Branch state changed from on review to approved
comment:7 Changed 13 years ago by slavazanko
- Status changed from accepted to testing
- Votes for changeset changed from angel_il amdrew_b to commited-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [4dde8ca1ddb36c3117c29eae0f6b6a30cc1fea82]
git log --pretty=oneline 6f13867..ccb6de9
comment:8 Changed 13 years ago by slavazanko
- Keywords stable-candidate removed
- Status changed from testing to closed
- Votes for changeset changed from commited-master to commited-master commited-stable
Merged to stable:
git log --pretty=oneline ebb5c99..729aaed
comment:9 Changed 9 years ago by ag
What are the reasons to add and prefer perl over touch? The nanosecond precision [1] would work with touch, but since I can't find "perl utimensat" I'm not sure it would work so easy with perl (without additional modules).
comment:10 Changed 9 years ago by zaytsev
I think that the original motivation for preferring Perl in all cases for FISH if it is available at all was compatibility. We have constantly had problems with FISH scripts not working properly in various settings due to non-POSIXness of available shells and tools, and Perl turned out to be a) very compatible and b) generally faster.
I'm not sure that it's worth reversing the defaults here...
