Ticket #260 (closed defect: fixed)
fix missing include files
| Reported by: | metux | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.0-pre1 |
| Component: | mc-core | Version: | 4.6.2 |
| Keywords: | commited-master | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description (last modified by metux) (diff)
Several .c files are missing some includes (which makes trouble under certain circumstances)
branch:260_fix_includes
changeset:4704d7300b63ca652fa82dd65c4896150605f1ff
Change History
comment:4 Changed 16 years ago by andrew_b
- Owner changed from metux to andrew_b
- Keywords rework added; review removed
- Status changed from accepted to assigned
mhl is need to be removed.
comment:5 Changed 16 years ago by andrew_b
- Keywords review added; rework removed
Rebased to current master.
Added other missed includes.
Added Changelog enties.
comment:6 Changed 16 years ago by andrew_b
- Milestone changed from 4.6.3 to 4.7
Rebased to current master
comment:9 Changed 16 years ago by slavazanko
branch 260_fix_includes now rebased to master
Review & vote.
comment:11 Changed 16 years ago by andrew_b
Rebased to current master.
comment:13 follow-up: ↓ 14 Changed 16 years ago by iNode
- Keywords vote-iNode added
Yeah, looks good. Please provide link to changeset to speed up review.
Should we now check sources to consistency with main/headers.txt rules
or it is deprecated and should be updated / removed?
comment:14 in reply to: ↑ 13 Changed 16 years ago by andrew_b
Replying to iNode:
Yeah, looks good. Please provide link to changeset to speed up review.
Currently, you can view the diff:
git diff -- b09a107190ad5725a401fa1f699fe71b2da39b1b^ 9ef324f7bbe1d00d4365a32984747d5ecebc365c
Should we now check sources to consistency with main/headers.txt rules
I think, yes.
or it is deprecated and should be updated / removed?
No.
comment:15 Changed 16 years ago by andrew_b
- Keywords commited-master added; review vote-slavazanko vote-iNode removed
- Status changed from assigned to testing
- Resolution set to fixed
Merged to master.
Start changeset:c7d04dd47a01bf2a42a56e2974c58c2c3d0812b6
End changeset:162bab7b70ba86f2dafe4177e80d251a4fbcba41
git log --pretty=oneline c7d04dd^..162bab7
