Ticket #2296 (closed defect: duplicate)
slang import broken
| Reported by: | metux | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | weigelt@…, zaytsev | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description
The slang importing is conceptionally broken:
a) it does not use the pkgconfig descriptor (PKG_CHECK_MODULES)
b) adds absolte pathes, which breaks many environments (especially crosscompiling)
Change History
comment:2 Changed 14 years ago by andrew_b
- Status changed from new to closed
- Resolution set to duplicate
comment:3 in reply to: ↑ 1 Changed 14 years ago by metux
Replying to zaytsev:
What's the point of creating a new ticket, when there's already #2139 dedicated to this issue?
Oh, sorry, forgot that there's already a ticket ... ;-o
Did you implement the fallback to the path-based configuration when pkgconfig script is not available as requested?
According to mc-with-screen-slang.m4, slang version >= 2.0 is required, which has an pkg-config descriptor.
So, detecting via compile-test is not just totally obsolete, but conceptionally wrong. (if the pkg-config descriptor is missing, the package is not properly installed).
Needless to say, that AC_TRY_RUN() _breaks_ any clean isolated build (not just crosscompiling).
What's the point of creating a new ticket, when there's already #2139 dedicated to this issue? Did you implement the fallback to the path-based configuration when pkgconfig script is not available as requested?