Build fixups (unused variables, etc)

[metux]

Branch:1872_build_fixups
changeset:393a08fac876097259f1587d4e278ce63f347c68

passed all tests, please vote asap as it's critical.

[angel_il]

will be fixed in #1845

[angel_il]

done: 3c680b630633f95b11240e65a096e8f892c6aeb6

[metux]

The branch also fixes some more things (eg. building w/o vfs).

[metux]

(In #1823) Still breaks on several things fixed by #1872

[metux]

rebased to current master, now running through testfarm ...

[slavazanko]

In changeset:413432283c22c38a5211176f4cca5e14b558189a present some MVFS stuff. Is these need to apply in this branch? May be better to move this stuff into special branch?

[metux]

Replying to slavazanko:

In changeset:413432283c22c38a5211176f4cca5e14b558189a present some MVFS stuff. Is these need to apply in this branch? May be better to move this stuff into special branch?

It's needed to fix problems w/ already present (but yet unused) mvfs stuff.

[metux]

Replying to angel_il:

What exactly does that change mean ?

Please keep in mind that we should merge it asap, as it's critical to get MC cleanly built at all.

[metux]

(In #1843) Buildfarm test still failed, since #1872 not merged yet ;-O

[metux]

(In #1906) Buildfarm test still fails, since #1872 not yet merged ;-o

[metux]

(In #1767) Didnt pass buildfarm test (see #1872)

[andrew_b]

(In #1906) Removed blockedby #1872 because this branch doesn't produce new compile warnings.

[slyfox]

I propose to move

    Ticket #1897: Fix compiler warnings/breaks on ignored result values which shouldnt be ignored                              
                                                                                                                               
    Glibc marks several functions, whose returns values should not be ignore,                                                  
    with warn_unused_resultwarn_unused_result.
                                                                                                                               
    Unfortunately we've got a lot of places where exactly these return values                                                  
    *are* ignored (eg. read(), write(), dup(), ... calls), so the compiler                                                     
    *breaks* when building w/ -Werror (which ought to be a MUST for any                                                        
    production build ;-o).                                                                                                     
                                                                                                                               
    Actually, we should have a closer look on it all, whether some results                                                     
    probably have to be handled (eg. to prevent possible leaks).

away from this branch to related #1897 and fix it in a better way: suppress silly warnings and really fix the rest.

Sprinkling 'if () {}' is very hard to read in the end result. I'd like to try another solution, like introducting

/* somewhere in global.h */
#ifdef __GNUC__ /* or something */
#define__mc_unused __attribute__((unused))
#else
#define__mc_unused
#endif /* __GNUC__ */

system("i don't care") __mc_unused;

I'm not sure if it will work though, but it would be ideal, as it's easily grepable and looks exactly the way glibc introduces wur :]

vfsdummy.h removal should contain 2 phases (as it's hard to review real changes in current state):

1. blind code move from vfsdummy.h to vfs.h

and

2. patching it.

(or the reverse, as it's easier to do right)

Then patch will look very small and I'll be happy to place a vote here.

[andrew_b]

(In #1843) Rebased to current master.
changeset:39ddea87eef200a064e418d7da0b3ac72c7b7649
changeset:b881a7b9ad1cac57d087bbae8e21fe323d199207

[slavazanko]

Branch have lot of conflicts when rebased on current master

[slavazanko]

Already in master

[andrew_b]

(In #1812) Replying to slavazanko:

Branch incompatible with current master

Partially commits of this branch are in the master one.