Ticket #1711 (closed defect: fixed)
i18n: context and cleanup in file prompt strings
| Reported by: | dmartina | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.0-pre4 |
| Component: | mc-core | Version: | 4.7.0-pre3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master |
Description
The "1" prefix trick may be perfectly handled by gettext using contexts. Also, there is no way to handle opening question marks ( '¿' as used in Spanish). The whole code seems to me a bit ugly...
I'm giving a preliminary patch proposal.
Attachments
Change History
Changed 15 years ago by dmartina
- Attachment action_dialogs.diff added
comment:2 Changed 15 years ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Milestone changed from 4.7 to 4.7.0-pre4
comment:3 Changed 15 years ago by andrew_b
- Blocked By 1705 removed
(In #1705) Merged to master.
git log --pretty=oneline db11ade..b48b537
comment:4 Changed 15 years ago by andrew_b
Created 1711_fileop_i18n branch. Parent branch: master.
Initial changeset:22f9b8ec8706fd17ef412b929af931d121ba076d
comment:6 Changed 15 years ago by dmartina
The TRANSLATORS warning: the array was split in several lines, so now the comment is two lines "away" from the strings; so message does not appear in .po files.
comment:7 Changed 15 years ago by andrew_b
Should the TRANSLATIONS: comment be inserted before each gettext context stuff?
comment:8 Changed 15 years ago by dmartina
I would not put these comments in excess, everywhere. But for now, context is used in just a couple of places, so I would put them both.
In the patch I sent there was just one message for the three strings and I think this is enough as they appear all together in the .po file.
comment:10 Changed 15 years ago by angel_il
- Votes for changeset changed from slavazanko to slavazanko angel_il
- severity changed from on review to approved
comment:11 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko angel_il to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
git log --pretty=oneline dc8c80c..bf8edba
i18n and improvements in prompt building