Ticket #168 (closed defect: fixed)
Unused and uninitialized variables
| Reported by: | winnie | Owned by: | winnie |
|---|---|---|---|
| Priority: | major | Milestone: | 4.6.2 |
| Component: | mc-core | Version: | 4.6.1 |
| Keywords: | vote-metux vote-slavazanko approved commited-stable-4.6 commited-master | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description
Here is a list of the warnings which raised up while compiling mc from git:
edit/editdraw.c: In function ‘edit_draw_this_line’:
edit/editdraw.c:285: warning: ‘tws’ may be used uninitialized in this function
edit/editlock.c: In function ‘lock_get_info’:
edit/editlock.c:146: warning: the address of ‘buf’ will always evaluate as ‘true’
src/cmd.c: In function ‘save_setup_cmd’:
src/cmd.c:1226: warning: unused variable ‘str’
src/util.c: In function ‘file_date’:
src/util.c:758: warning: unused variable ‘whentm’
src/util.c: In function ‘list_append_unique’:
src/util.c:1280: warning: ignoring return value of ‘g_list_remove_link’, declared with attribute warn_unused_result
As some of this issues needs a fix for 4.6.2 setting milestone to 4.6.2
Attachments
Change History
Changed 16 years ago by slavazanko
- Attachment 168_unused_uninitialised_vars.patch added
Some additionals to branch
comment:3 Changed 16 years ago by slavazanko
1) Winnie was create branch.
2) Metux was vote.
3) I'm attach some patch for branch.
Is my vote valid? And is vote to branch or to patch? Need to concretize.
comment:4 Changed 16 years ago by slavazanko
- Keywords vote-slavazanko approved added; review removed
Please have a view on branch 168_unused_uninitialised_vars.. this branch contains the fix.
Please review and vote :)