Changes between Version 1 and Version 2 of WorkingGuideLines
- Timestamp:
- 01/07/09 08:01:33 (16 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
WorkingGuideLines
v1 v2 15 15 * Bugfixes are allowed to go the the latest stable branch. These branches are called: mc-X.Y (e.g. mc-4.6), new features and restructurement are not allowed to go into a stable branch, but should go into the next full release. This patch then should go into the master branch. Please also choose the correct milestone for this ticket: For a bugfix choose the latest milestone from the stable branch (e.g. 4.6.2) for a new feature choose the default (which is atm 4.7). 16 16 * Create on top of the appropiate branch another branch (e.g for a bugfix create a branch on top of mc-4.6) This branch should follow some easy naming rules: XYZ_<something_descriptive_here>. XYZ is here the ID of the ticket. The patch is not directly applied to the parent branch as we would like to review it beforehand. 17 * After creating the branch, you should not forget to add this keyword: "review" to your ticket, since now your ticket will pop up on $MISSING_LINKand can be reviewed by other developers.17 * After creating the branch, you should not forget to add this keyword: "review" to your ticket, since now your ticket will pop up on [http://www.midnight-commander.org/report/9 this page] and can be reviewed by other developers. 18 18 19 19 == Reviewing Ticket Guidelines == 20 20 As there are some guidelines for creating tickets, there are of course also some guidelines for reviewing tickets. 21 * Tickets which needs a review are located here: $MISSING_LINK21 * Tickets which needs a review are located here: http://www.midnight-commander.org/report/9 22 22 * You can directly test the patch in git, simply checkout this branch and test and review it. 23 23 * This should be reviewed when looking at a patch: